fix: also consider Accept header in addition to Content-Type #138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing decisions on media type
|
@daveshanley for your consideration |
daveshanley
approved these changes
Oct 24, 2024
|
@daveshanley Nice! Let me know if I can do anything else to help. FYI I don't have permissions to merge. |
Will merge today, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that the
Acceptheader was not considered when wiretap was selecting from possible mock responses, while theContent-Typeheader was.This change makes wiretap consider the client's Accept header (as a very basic form of mocking content negotation) when deciding what if any example should be used for a mock response.