Revert back to go-github v32 #261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In v33, the library removed some preview media type headers that are still required in GitHub Enterprise, although they are no longer required on GitHub.com. Until there's a GHE release that drops the requirement for the preview media types, we'll need to stick with the older version. Since we otherwise weren't taking advantage of new features or changes, this should be fine.
IainSteers
approved these changes
Jan 21, 2021
Member
|
The header has graduated as part of GHE 3.0: https://docs.github.com/en/[email protected]/rest/reference/checks#create-a-check-run--parameters, so we should be safe to update once again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In v33, the library removed some preview media type headers that are still required in GitHub Enterprise, although they are no longer required on GitHub.com. Until there's a GHE release that drops the requirement for the preview media types, we'll need to stick with the older version.
Since we otherwise weren't taking advantage of new features or changes, this should be fine.
The Checks API headers removed in google/go-github#1636 are the specific ones we care about.