Skip to content

Introduce radiance_factor calibration level #3292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 34 commits into
base: main
Choose a base branch
from
Draft

Introduce radiance_factor calibration level #3292

wants to merge 34 commits into from

Conversation

@mraspaud
Copy link
Member

@mraspaud mraspaud commented Nov 11, 2025 •
edited
Loading

This PR introduce the radiance_factor calibration level to refer to reflectance not yet normalised by the solar pathlength, along with the corresponding standard name.

  • Closes #xxxx
  • Tests added
  • Fully documented
  • abi_l1b.yaml
  • abi_l1b_scmi.yaml
  • abi_l2_nc.yaml
  • acspo.yaml - no changes
  • agri_fy4a_l1.yaml
  • agri_fy4b_l1.yaml
  • ahi_hrit.yaml
  • ahi_hsd.yaml
  • ahi_l1b_gridded_bin.yaml - reference says the data are reflectances, not touched
  • ahi_l2_nc.yaml - no changes
  • ami_l1b.yaml
  • amsr2_l1b.yaml - no changes
  • amsr2_l2.yaml - no changes
  • amsr2_l2_gaasp.yaml - no changes
  • amsub_l1c_aapp.yaml - no changes
  • ascat_l2_soilmoisture_bufr.yaml - no changes
  • atms_l1b_nc.yaml - no changes
  • atms_sdr_hdf5.yaml - no changes
  • avhrr_l0_hrpt.yaml
  • avhrr_l1b_aapp.yaml
  • avhrr_l1b_eps.yaml
  • avhrr_l1b_gaclac.yaml
  • avhrr_l1c_eum_gac_fdr_nc.yaml
  • aws1_mwr_l1b_nc.yaml - no changes
  • aws1_mwr_l1c_nc.yaml - no changes
  • caliop_l2_cloud.yaml - no changes
  • camel_l3_nc.yaml - no changes
  • clavrx.yaml - no changes
  • cmsaf-claas2_l2_nc.yaml - no changes
  • electrol_hrit.yaml - no changes
  • epic_l1b_h5.yaml - no changes
  • eps_sterna_mwr_l1b_nc.yaml
  • etm_l1_tif.yaml - "real" reflectance: Top of the Atmosphere Reflectance, which is obtained using the scene center sun angle
  • etm_l2_tif.yaml - surface reflectance
  • fci_l1c_nc.yaml
  • fci_l2_bufr.yaml - no changes
  • fci_l2_grib.yaml - no changes
  • fci_l2_nc.yaml - should this be left as-is even if the values are not the true reflectance?
  • fy3a_mersi1_l1b.yaml
  • fy3b_mersi1_l1b.yaml
  • fy3c_mersi1_l1b.yaml
  • generic_image.yaml - no changes
  • geocat.yaml
  • gerb_l2_hr_h5.yaml - no changes
  • ghi_l1.yaml
  • ghrsst_l2.yaml
  • gld360_ualf2.yaml
  • glm_l2.yaml
  • gms5-vissr_l1b.yaml
  • goci2_l2_nc.yaml
  • goes-imager_hrit.yaml
  • goes-imager_nc.yaml
  • gpm_imerg.yaml
  • grib.yaml
  • hsaf_grib.yaml
  • hsaf_h5.yaml
  • hy2_scat_l2b_h5.yaml
  • iasi_l2.yaml
  • iasi_l2_cdr_nc.yaml
  • iasi_l2_so2_bufr.yaml
  • iasi_ng_l2_nc.yaml
  • ici_l1b_nc.yaml
  • insat3d_img_l1b_h5.yaml
  • jami_hrit.yaml
  • li_l2_nc.yaml
  • maia.yaml
  • mcd12q1.yaml
  • meris_nc_sen3.yaml
  • mersi2_l1b.yaml
  • mersi3_l1b.yaml
  • mersi_ll_l1b.yaml
  • mersi_rm_l1b.yaml
  • mhs_l1c_aapp.yaml
  • mimicTPW2_comp.yaml
  • mirs.yaml
  • modis_l1b.yaml
  • modis_l2.yaml
  • modis_l3.yaml
  • msi_l1c_earthcare.yaml
  • msi_safe.yaml
  • msi_safe_l2a.yaml
  • mss_l1_tif.yaml
  • msu_gsa_l1b.yaml
  • mtsat2-imager_hrit.yaml
  • multiple_sensors_isccpng_l1g_nc.yaml
  • mviri_l1b_fiduceo_nc.yaml
  • mwi_l1b_nc.yaml
  • mws_l1b_nc.yaml
  • nucaps.yaml
  • nwcsaf-geo.yaml
  • nwcsaf-msg2013-hdf5.yaml
  • nwcsaf-pps_nc.yaml
  • oceancolorcci_l3_nc.yaml
  • oci_l2_bgc.yaml
  • olci_l1b.yaml
  • olci_l2.yaml
  • oli_tirs_l1_tif.yaml
  • oli_tirs_l2_tif.yaml
  • omps_edr.yaml
  • osisaf_nc.yaml
  • pace_oci_l1b_nc.yaml - no changes
  • safe_sar_l2_ocn.yaml - no changes
  • sar-c_safe.yaml - no changes
  • satpy_cf_nc.yaml
  • scatsat1_l2b.yaml - no changes
  • seadas_l2.yaml - no changes
  • seviri_l1b_hrit.yaml
  • seviri_l1b_icare.yaml
  • seviri_l1b_native.yaml
  • seviri_l1b_nc.yaml
  • seviri_l2_bufr.yaml - no changes
  • seviri_l2_grib.yaml - no changes
  • sgli_l1b.yaml
  • slstr_l1b.yaml
  • smos_l2_wind.yaml - no changes
  • tm_l1_tif.yaml - no changes
  • tm_l2_tif.yaml - no changes
  • tropomi_l2.yaml - no changes
  • vii_l1b_nc.yaml
  • vii_l2_nc.yaml
  • viirs_compact.yaml
  • viirs_edr.yaml - no changes
  • viirs_edr_active_fires.yaml - no changes
  • viirs_edr_flood.yaml - no changes
  • viirs_l1b.yaml
  • viirs_l2.yaml - no changes
  • viirs_sdr.yaml
  • viirs_vgac_l1c_nc.yaml
  • virr_l1b.yaml

@mraspaud mraspaud self-assigned this Nov 11, 2025
@mraspaud mraspaud added enhancement code enhancements, features, improvements refactor PCW Pytroll Contributors' Week labels Nov 11, 2025
@ameraner ameraner mentioned this pull request Nov 11, 2025
Open
@codecov
Copy link

codecov bot commented Nov 11, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 98.71245% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.31%. Comparing base (b02f62d) to head (202a407).
⚠️ Report is 82 commits behind head on main.

Files with missing lines Patch % Lines
satpy/readers/viirs_compact.py 50.00% 2 Missing ⚠️
satpy/readers/seviri_l1b_hrit.py 75.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff            @@
##             main    #3292    +/-   ##
========================================
  Coverage   96.30%   96.31%            
========================================
  Files         463      463            
  Lines       58307    59016   +709     
========================================
+ Hits        56155    56839   +684     
- Misses       2152     2177    +25
Flag Coverage Δ
behaviourtests 3.60% <0.00%> (-0.04%) ⬇️
unittests 96.40% <98.71%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coveralls
Copy link

coveralls commented Nov 12, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 19365456107

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 233 unchanged lines in 25 files lost coverage.
  • Overall coverage increased (+0.007%) to 96.387%
Files with Coverage Reduction New Missed Lines %
readers/abi_l1b.py 1 98.9%
readers/hrit_jma.py 1 99.33%
readers/hrpt.py 1 98.67%
tests/reader_tests/test_ahi_hrit.py 1 99.47%
writers/init.py 1 76.92%
readers/mersi_l1b.py 2 98.57%
readers/slstr_l1b.py 2 97.5%
tests/compositor_tests/test_aux_data.py 2 97.33%
tests/reader_tests/test_abi_l1b.py 2 98.97%
writers/geotiff.py 2 91.78%
Totals Coverage Status
Change from base Build 19264575612: 0.007%
Covered Lines: 56717
Relevant Lines: 58843
💛 - Coveralls

@ameraner ameraner moved this to In Progress in Remote PCW Autumn 2025 Nov 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@djhoese djhoese Awaiting requested review from djhoese djhoese will be requested when the pull request is marked ready for review djhoese is a code owner

@sjoro sjoro Awaiting requested review from sjoro sjoro will be requested when the pull request is marked ready for review sjoro is a code owner

@sfinkens sfinkens Awaiting requested review from sfinkens sfinkens will be requested when the pull request is marked ready for review sfinkens is a code owner

@ameraner ameraner Awaiting requested review from ameraner ameraner will be requested when the pull request is marked ready for review ameraner is a code owner

@gerritholl gerritholl Awaiting requested review from gerritholl gerritholl will be requested when the pull request is marked ready for review gerritholl is a code owner

@pnuu pnuu Awaiting requested review from pnuu pnuu will be requested when the pull request is marked ready for review pnuu is a code owner

@adybbroe adybbroe Awaiting requested review from adybbroe adybbroe will be requested when the pull request is marked ready for review adybbroe is a code owner

Assignees

@mraspaud mraspaud

Labels

enhancement code enhancements, features, improvements PCW Pytroll Contributors' Week refactor

Projects

Remote PCW Autumn 2025
Status: In Progress
SatPy 1.0 Release
Status: No status

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mraspaud @coveralls @lahtinep