-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
PEP 806: Mixed sync/async context managers with precise async marking #4581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
with async
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks! A couple minor points left.
Are you already working on a reference implementation? I started fiddling with the grammar a bit but not sure I'll have time to fully implement the PEP.
I'm not working on a reference implementation at the moment, but of course if you want to sponsor the PEP without implementing it that's totally fine! |
ad04138
to
0af6520
Compare
0af6520
to
6859bbf
Compare
@Zac-HD please don't force push if you can avoid it. A |
with thanks to Adam Turner for his detailed review ❤️ Co-authored-by: Adam Turner <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added the new PEP checklist from https://github.com/python/peps/blob/main/.github/PULL_REQUEST_TEMPLATE/Add%20a%20new%20PEP.md to the top post, please could you go through it and mark off those that apply?
Co-authored-by: Hugo van Kemenade <[email protected]> Co-authored-by: Liam DeVoe <[email protected]>
With thanks to everyone who I've discussed this with; especially to Rob Rolls on Discuss for the ultimate proposal here, and to Jelle for offering to sponsor the PEP here.
Basic requirements (all PEP Types)
pep-NNNN.rst
), PR title (PEP 123: <Title of PEP>
) andPEP
headerAuthor
orSponsor
, and formally confirmed their approvalAuthor
,Status
(Draft
),Type
andCreated
headers filled out correctlyPEP-Delegate
,Topic
,Requires
andReplaces
headers completed if appropriate.github/CODEOWNERS
for the PEPStandards Track requirements
Python-Version
set to valid (pre-beta) future Python version, if relevantDiscussions-To
andPost-History
📚 Documentation preview 📚: https://pep-previews--4581.org.readthedocs.build/