Skip to content

gh-93925: Improve doc clarity of sqlite3 commit/rollback, and close #93926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
erlend-aasland merged 3 commits into from
Jun 19, 2022
Merged

gh-93925: Improve doc clarity of sqlite3 commit/rollback, and close #93926

erlend-aasland merged 3 commits into from
Jun 19, 2022

Conversation

@erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Jun 17, 2022

No description provided.

@erlend-aasland erlend-aasland linked an issue Jun 17, 2022 that may be closed by this pull request
Improve docs/docstrings of sqlite3 commit()/rollback() and close() #93925
Closed
@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Jun 17, 2022

Followup of #93890

@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Jun 17, 2022

cc. @python/proofreaders

erlend-aasland
erlend-aasland commented Jun 17, 2022
View reviewed changes
bskinn
bskinn reviewed Jun 17, 2022
View reviewed changes
bskinn
bskinn reviewed Jun 17, 2022
View reviewed changes
erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull request Jun 17, 2022
@erlend-aasland
Clarify execute*, commit, rollback, and close
341e0dd 
- execute*(): Explain that DML queries implicitly open transactions if
  autocommit is in compat mode.
- commit/rollback/close: incorporate pythongh-93926 changes
CAM-Gerlach
CAM-Gerlach reviewed Jun 18, 2022
View reviewed changes
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, aside from a couple minor suggested textual tweaks. Thanks!

CAM-Gerlach
CAM-Gerlach approved these changes Jun 18, 2022
View reviewed changes
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now; thanks @erlend-aasland ✔️

pradyunsg
pradyunsg approved these changes Jun 18, 2022
View reviewed changes
Copy link
Member

@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! ^>^

@mwichmann
Copy link

mwichmann commented Jun 18, 2022

I haz no approval privileges, but I'll still say this is clearly an improvement :)

@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Jun 19, 2022

Thanks for the reviews. Highly appreciated.

@erlend-aasland erlend-aasland merged commit 6446592 into python:main Jun 19, 2022
@erlend-aasland erlend-aasland added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Jun 19, 2022
@miss-islington
Copy link
Contributor

miss-islington commented Jun 19, 2022

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Jun 19, 2022

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@erlend-aasland erlend-aasland deleted the sqlite-doc-commit-rollback branch June 19, 2022 19:17
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 19, 2022
@miss-islington
pythongh-93925: Improve clarity of sqlite3 commit/rollback, and close…
c16f5d6 
… docs (pythonGH-93926)

Co-authored-by: CAM Gerlach <[email protected]>
(cherry picked from commit 6446592)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
@miss-islington
Copy link
Contributor

miss-islington commented Jun 19, 2022

Sorry, @erlend-aasland, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 6446592c89b0c581c00e170ae6278291e940755c 3.10

@bedevere-bot
Copy link

bedevere-bot commented Jun 19, 2022

GH-94010 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jun 19, 2022
erlend-aasland pushed a commit to erlend-aasland/cpython that referenced this pull request Jun 19, 2022
@erlend-aasland
[3.10] pythongh-93925: Improve clarity of sqlite3 commit/rollback, an…
5097a8f 
…d close docs (pythonGH-93926)

Co-authored-by: CAM Gerlach <[email protected]>.
(cherry picked from commit 6446592)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
@bedevere-bot
Copy link

bedevere-bot commented Jun 19, 2022

GH-94011 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jun 19, 2022
erlend-aasland pushed a commit that referenced this pull request Jun 19, 2022
[3.10] gh-93925: Improve clarity of sqlite3 commit/rollback, and clos…
c4440e6 
…e docs (GH-93926) (#94011)

Co-authored-by: CAM Gerlach <[email protected]>.
(cherry picked from commit 6446592)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
miss-islington added a commit that referenced this pull request Jun 19, 2022
@miss-islington
gh-93925: Improve clarity of sqlite3 commit/rollback, and close docs (G…
8b068c4 
…H-93926)

Co-authored-by: CAM Gerlach <[email protected]>
(cherry picked from commit 6446592)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
@erlend-aasland erlend-aasland mentioned this pull request Jun 19, 2022
Closed
serhiy-storchaka added a commit that referenced this pull request Jun 26, 2022
@serhiy-storchaka @iritkatriel
@ulisesojeda @jackh-ncl @mdickinson @colin99d @nascheme @tiran @sweeneyde @cykerway @hugovk @slateny @graingert @illia-v @erlend-aasland @AlexWaygood @aisk @sransara @sorcio @pSub @vsajip @AA-Turner @ambv @agrommek @markshannon @Fidget-Spinner @adriangb @jacksonriley @rawwar @Bluenix2 @encukou @CAM-Gerlach @seberg @jxdabc @pitrou @neonene @zooba @pablogsal @barneygale @arhadthedev @brettcannon @belm0 @JulienPalard @pamelafox @corona10 @kumaraditya303 @vstinner @TechieBoy @youknowone @samtygier @brandtbucher @gpshead @chilaxan @cfernald @jaraco @ezio-melotti @leikdga @itssme @mkoeppe @MilanJuhas @luzpaz @paulreece @pr2502 @JelleZijlstra @tacaswell @Windsooon @carlbordum @ethanfurman @merwok @chgnrdv @fikotta @partev @terryjreedy @methane @oscar-LT @wookie184 @gvanrossum @myronww @dignissimus @GBeauregard @jarondl
Revert 30935 defer bpo45162 to 312 (#94285)
1ffde3e 
* GH-93444: remove redundant fields from basicblock: b_nofallthrough, b_exit, b_return (GH-93445)

* netrc: Remove unused "import shlex" (#93311)

* gh-92886: Fix test that fails when running with `-O` in `test_imaplib.py` (#93237)

* Fix missing word in sys.float_info docstring (GH-93489)

* [doc] Correct a grammatical error in a docstring. (GH-93441)

* gh-93442: Make C++ version of _Py_CAST work with 0/NULL. (#93500)

Add C++ overloads for _Py_CAST_impl() to handle 0/NULL.  This will allow
C++ extensions that pass 0 or NULL to macros using _Py_CAST() to
continue to compile.  Without this, you get an error like:

    invalid ‘static_cast’ from type ‘int’ to type ‘_object*’

The modern way to use a NULL value in C++ is to use nullptr.  However,
we want to not break extensions that do things the old way.

Co-authored-by: serge-sans-paille

* gh-93442: Add test for _Py_CAST(nullptr). (gh-93505)

* gh-90473: wasmtime does not support absolute symlinks (GH-93490)

* gh-89973: Fix re.error in the fnmatch module. (GH-93072)

Character ranges with upper bound less that lower bound (e.g. [c-a])
are now interpreted as empty ranges, for compatibility with other glob
pattern implementations. Previously it was re.error.

* Document LOAD_FAST_CHECK opcode (#93498)

* gh-93247: Fix assert function in asyncio locks test (#93248)

* gh-90473: WASI requires proper open(2) flags (GH-93529)

* GH-92308 What's New: list pending removals in 3.13 and future versions (#92562)

* gh-90473: Skip POSIX tests that don't apply to WASI (GH-93536)

* asyncio.Barrier docs: Fix typo (#93371)

taks -> tasks

* gh-83728: Add hmac.new default parameter deprecation (