Skip to content

gh-91731: Don't define 'static_assert' in C++11 where is a keyword to avoid UB #93700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pablogsal merged 2 commits into from
Jun 13, 2022
Merged

gh-91731: Don't define 'static_assert' in C++11 where is a keyword to avoid UB #93700

pablogsal merged 2 commits into from
Jun 13, 2022

Conversation

@pablogsal
Copy link
Member

@pablogsal pablogsal commented Jun 10, 2022

No description provided.

@pablogsal pablogsal added the needs backport to 3.11 only security fixes label Jun 10, 2022
AA-Turner
AA-Turner reviewed Jun 11, 2022
View reviewed changes
vstinner
vstinner approved these changes Jun 13, 2022
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Misc/NEWS.d/next/Core and Builtins/2022-06-10-23-41-48.gh-issue-91731.fhYUQG.rst Outdated
Copy link
Member

@vstinner vstinner Jun 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can move this NEWS entry to Build, or C API, category.

@vstinner vstinner mentioned this pull request Jun 13, 2022
Closed
@pablogsal pablogsal merged commit 65ff27c into python:main Jun 13, 2022
@miss-islington
Copy link
Contributor

miss-islington commented Jun 13, 2022

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@pablogsal pablogsal added needs backport to 3.11 only security fixes and removed needs backport to 3.11 only security fixes labels Jun 16, 2022
@miss-islington
Copy link
Contributor

miss-islington commented Jun 16, 2022

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@pablogsal pablogsal deleted the 91731 branch June 16, 2022 14:25
@bedevere-bot
Copy link

bedevere-bot commented Jun 16, 2022

GH-93907 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jun 16, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 16, 2022
@pablogsal @miss-islington
pythongh-91731: Don't define 'static_assert' in C++11 where is a keyw…
491392a 
…ord to avoid UB (pythonGH-93700)

(cherry picked from commit 65ff27c)

Co-authored-by: Pablo Galindo Salgado <[email protected]>
miss-islington added a commit that referenced this pull request Jun 16, 2022
@miss-islington @pablogsal
gh-91731: Don't define 'static_assert' in C++11 where is a keyword to…
7456109 
… avoid UB (GH-93700)

(cherry picked from commit 65ff27c)

Co-authored-by: Pablo Galindo Salgado <[email protected]>
serhiy-storchaka added a commit that referenced this pull request Jun 26, 2022
@serhiy-storchaka @iritkatriel
@ulisesojeda @jackh-ncl @mdickinson @colin99d @nascheme @tiran @sweeneyde @cykerway @hugovk @slateny @graingert @illia-v @erlend-aasland @AlexWaygood @aisk @sransara @sorcio @pSub @vsajip @AA-Turner @ambv @agrommek @markshannon @Fidget-Spinner @adriangb @jacksonriley @rawwar @Bluenix2 @encukou @CAM-Gerlach @seberg @jxdabc @pitrou @neonene @zooba @pablogsal @barneygale @arhadthedev @brettcannon @belm0 @JulienPalard @pamelafox @corona10 @kumaraditya303 @vstinner @TechieBoy @youknowone @samtygier @brandtbucher @gpshead @chilaxan @cfernald @jaraco @ezio-melotti @leikdga @itssme @mkoeppe @MilanJuhas @luzpaz @paulreece @pr2502 @JelleZijlstra @tacaswell @Windsooon @carlbordum @ethanfurman @merwok @chgnrdv @fikotta @partev @terryjreedy @methane @oscar-LT @wookie184 @gvanrossum @myronww @dignissimus @GBeauregard @jarondl
Revert 30935 defer bpo45162 to 312 (#94285)
1ffde3e 
* GH-93444: remove redundant fields from basicblock: b_nofallthrough, b_exit, b_return (GH-93445)

* netrc: Remove unused "import shlex" (#93311)

* gh-92886: Fix test that fails when running with `-O` in `test_imaplib.py` (#93237)

* Fix missing word in sys.float_info docstring (GH-93489)

* [doc] Correct a grammatical error in a docstring. (GH-93441)

* gh-93442: Make C++ version of _Py_CAST work with 0/NULL. (