Skip to content

GH-141509: Fix warning about remaining subinterpreters #141528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ZeroIntensity merged 8 commits into from
Nov 14, 2025
Merged

GH-141509: Fix warning about remaining subinterpreters #141528

ZeroIntensity merged 8 commits into from
Nov 14, 2025

Conversation

@sergey-miryanov
Copy link
Contributor

@sergey-miryanov sergey-miryanov commented Nov 13, 2025 •
edited by bedevere-app bot
Loading

Fix warning - suggest using Interpreter.close instead of _interpeters.destroy.

@ZeroIntensity Could you please take a look?

@bedevere-app bedevere-app bot mentioned this pull request Nov 13, 2025
Closed
ZeroIntensity
ZeroIntensity reviewed Nov 13, 2025
View reviewed changes
Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. This changes a public API, so let's add a news entry.
  2. Since you didn't need to update any tests, that means that this code path is untested. Please add a test case for leaving subinterpreters unclosed.

@sergey-miryanov sergey-miryanov marked this pull request as draft November 13, 2025 19:19