Skip to content

gh-121160: Note that readline libraries using different history formats. #121327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
encukou merged 1 commit into from
Jul 19, 2024
Merged

gh-121160: Note that readline libraries using different history formats. #121327

encukou merged 1 commit into from
Jul 19, 2024

Conversation

@encukou
Copy link
Member

@encukou encukou commented Jul 3, 2024 •
edited by github-actions bot
Loading

This is not something we can do too much about, without help from the underlying libraries.

The file formats seem to be treated as implementation details, hidden behind API calls.

📚 Documentation preview 📚: https://cpython-previews--121327.org.readthedocs.build/

@encukou
pythongh-121160: Note that readline libraries using different history…
258d375 
… formats.

This is not something we can do too much about, without help from the
underlying libraries.
@encukou encukou added the docs Documentation in the Doc dir label Jul 3, 2024
@bedevere-app bedevere-app bot mentioned this pull request Jul 3, 2024
Closed
@encukou
Copy link
Member Author

encukou commented Jul 4, 2024

@Yhg1s, you're the readline expert. Does this look good?

@encukou
Copy link
Member Author

encukou commented Jul 19, 2024

I'll merge next week.

@Yhg1s
Copy link
Member

Yhg1s commented Jul 19, 2024

Eehh, "expert"... But yeah, I think this is the only thing we can do here.

@encukou
Copy link
Member Author

encukou commented Jul 19, 2024

Thanks!

Expert just means you've signed up for notifications about tricky or controversial changes :)

@encukou encukou merged commit 709db44 into python:main Jul 19, 2024
@encukou encukou deleted the readline-history-doc branch July 19, 2024 13:52
@encukou encukou added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Jul 19, 2024
@miss-islington-app
Copy link

miss-islington-app bot commented Jul 19, 2024

Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app
Copy link

miss-islington-app bot commented Jul 19, 2024

Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington-app
Copy link

miss-islington-app bot commented Jul 19, 2024

Sorry, @encukou, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 709db44255eb5d73fc22a1341dd0253e71ddfda9 3.12