Skip to content

Increase stack reserve size for Windows debug builds to avoid test crashes #102764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zooba merged 1 commit into from
Mar 17, 2023
Merged

Increase stack reserve size for Windows debug builds to avoid test crashes #102764

zooba merged 1 commit into from
Mar 17, 2023

Conversation

@zooba
Copy link
Member

@zooba zooba commented Mar 16, 2023

No description provided.

@zooba zooba requested a review from a team as a code owner March 16, 2023 19:34
@zooba zooba added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Mar 16, 2023
@bedevere-bot
Copy link

bedevere-bot commented Mar 16, 2023

🤖 New build scheduled with the buildbot fleet by @zooba for commit b5e9d46 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Mar 16, 2023
@python python deleted a comment from bedevere-bot Mar 16, 2023
@python python deleted a comment from bedevere-bot Mar 16, 2023
@zooba
Copy link
Member Author

zooba commented Mar 16, 2023

!buildbot .ARM64.

@bedevere-bot
Copy link

bedevere-bot commented Mar 16, 2023

🤖 New build scheduled with the buildbot fleet by @zooba for commit b5e9d46 🤖

The command will test the builders whose names match following regular expression: .*ARM64.*

The builders matched are:

  • ARM64 macOS PR
  • ARM64 Windows Non-Debug PR
  • ARM64 Windows PR

@zooba zooba merged commit f33b33e into python:main Mar 17, 2023
@miss-islington
Copy link
Contributor

miss-islington commented Mar 17, 2023

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@zooba zooba deleted the debugmem branch March 17, 2023 01:07
@miss-islington
Copy link
Contributor

miss-islington commented Mar 17, 2023

Sorry, @zooba, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker f33b33eb31c11a32b2955eb1f002f02267bd7d61 3.10

@bedevere-bot
Copy link

bedevere-bot commented Mar 17, 2023

GH-102770 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Mar 17, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 17, 2023
@zooba @miss-islington
Increase stack reserve size for Windows debug builds to avoid test cr…
e1e8e06 
…ashes (pythonGH-102764)

(cherry picked from commit f33b33e)

Co-authored-by: Steve Dower <[email protected]>
miss-islington added a commit that referenced this pull request Mar 17, 2023
@miss-islington @zooba
Increase stack reserve size for Windows debug builds to avoid test cr…
d025b1d 
…ashes (GH-102764)

(cherry picked from commit