Skip to content

gh-100739: Respect mock spec when checking for unsafe prefixes #100740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cjw296 merged 2 commits into from
Jan 4, 2023
Merged

gh-100739: Respect mock spec when checking for unsafe prefixes #100740

cjw296 merged 2 commits into from
Jan 4, 2023

Conversation

@cklein
Copy link
Contributor

@cklein cklein commented Jan 4, 2023 •
edited by AlexWaygood
Loading

Respect Mock spec for attribute names starting with assert (and typos)

@cklein cklein requested a review from cjw296 as a code owner January 4, 2023 07:24
@bedevere-bot bedevere-bot mentioned this pull request Jan 4, 2023
Closed
@bedevere-bot
Copy link

bedevere-bot commented Jan 4, 2023

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

sobolevn
sobolevn reviewed Jan 4, 2023
View reviewed changes
@cklein cklein requested review from sobolevn and removed request for cjw296 January 4, 2023 10:24
@sobolevn sobolevn requested review from cjw296 and removed request for sobolevn January 4, 2023 10:28
carljm
carljm reviewed Jan 4, 2023
View reviewed changes
@carljm
Copy link
Member

carljm commented Jan 4, 2023

(Note, generally don't ever force-push to a PR, it disrupts incremental review. The commits will be squashed on merge anyway, so there's no harm in having the PR be a series of commits reflecting its development.)

carljm
carljm approved these changes Jan 4, 2023
View reviewed changes
Copy link
Member

@carljm carljm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, thanks for the fix!

@cjw296 cjw296 merged commit 7f1eefc into python:main Jan 4, 2023
@AlexWaygood AlexWaygood added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Jan 4, 2023
@miss-islington
Copy link
Contributor

miss-islington commented Jan 4, 2023

Thanks @cklein for the PR, and @cjw296 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington