Drop 3.9 support #3345
Merged
Drop 3.9 support #3345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3345 +/- ##
================================================
Coverage 100.00000% 100.00000%
================================================
Files 125 125
Lines 19598 19388 -210
Branches 1344 1319 -25
================================================
- Hits 19598 19388 -210
🚀 New features to boost your workflow:
|
CoolCat467
reviewed
Oct 17, 2025
for more information, see https://pre-commit.ci
CoolCat467
approved these changes
Oct 18, 2025
- Fix a few typos - Remove unnecessary generic function infrastructure - Deduplicate `from typing import ...` imports - Fix codecov complains
I'm not so sure about the unix pipes change. I suppose we'll get comments if it doesn't work? I can't tell why the code was there to begin with, which is a bad sign for being able to tell whether it's necessary anymore.
CoolCat467
reviewed
Oct 18, 2025
Contributor
Author
|
Planning on merging this in a few days unless people have concerns. |
jakkdl
approved these changes
Oct 27, 2025
Member
jakkdl
left a comment
There was a problem hiding this comment.
looks good! Did not catch anything of note when reading through
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also notes that we support 3.14 now.