Nursery.start() doesn't specifically return None #3224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A5rocks
approved these changes
Mar 13, 2025
Contributor
A5rocks
left a comment
There was a problem hiding this comment.
Yeah this makes sense. I don't really think it even matters whether it specifically returns None or not; it's just kind of irrelevant. (... if we want people to check, we should return object. If we don't, then Any. Any | something just doesn't really make sense)
CoolCat467
approved these changes
Mar 13, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3224 +/- ##
================================================
Coverage 100.00000% 100.00000%
================================================
Files 124 124
Lines 18764 19244 +480
Branches 1269 1353 +84
================================================
+ Hits 18764 19244 +480
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed this,
start()was set toAny | None, but it never specifically returnsNone, only if you callstarted()with no parameter on aTaskStatus[None]. If you're using a different task status, forcingNonechecks is just wrong.