Skip to content

[Feature] CSVLogger #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 24, 2022
Merged

[Feature] CSVLogger #372

merged 5 commits into from
Aug 24, 2022

Conversation

@vmoens
Copy link
Collaborator

@vmoens vmoens commented Aug 22, 2022 •
edited
Loading

Description

  • Implements a CSVLogger, which requires no additional package
  • Implements tests for loggers. Missing:
    • Video
    • Text

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 22, 2022
@vmoens vmoens requested a review from nicolas-dufour August 22, 2022 08:53
@vmoens vmoens added the bug Something isn't working label Aug 22, 2022
@vmoens vmoens merged commit 17ef664 into main Aug 24, 2022
@vmoens vmoens deleted the csvlogger branch August 24, 2022 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nicolas-dufour nicolas-dufour Awaiting requested review from nicolas-dufour

Assignees

No one assigned

Labels

bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vmoens @facebook-github-bot