Skip to content

[BugFix] Fix a build warning, setuptools/distutils import order #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 20, 2022
Merged

[BugFix] Fix a build warning, setuptools/distutils import order #307

merged 1 commit into from
Jul 20, 2022

Conversation

@nairbv
Copy link
Contributor

@nairbv nairbv commented Jul 20, 2022

when building locally I was getting the below build warning. Changing import order seems to fix it.

/Users/bvaughan/anaconda3/lib/python3.7/site-packages/setuptools/distutils_patch.py:26: UserWarning: Distutils was imported before Setuptools. This usage is discouraged and may exhibit undesirable behaviors or errors. Please use Setuptools' objects directly or at least import Setuptools first.
  "Distutils was imported before Setuptools. This usage is discouraged "

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 20, 2022
vmoens
vmoens approved these changes Jul 20, 2022
View reviewed changes
Copy link
Collaborator

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch thanks for this

@vmoens vmoens changed the title fix a build warning, setuptools/distutils import order [BugFix] Fix a build warning, setuptools/distutils import order Jul 20, 2022
@vmoens vmoens merged commit 8c9bd48 into pytorch:main Jul 20, 2022
@nairbv nairbv mentioned this pull request Jul 20, 2022
Merged
@vmoens vmoens mentioned this pull request Jul 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vmoens vmoens vmoens approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nairbv @vmoens @facebook-github-bot