Skip to content

[Quality] Use relative imports for local c++ deps #526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 6, 2022
Merged

[Quality] Use relative imports for local c++ deps #526

merged 1 commit into from
Oct 6, 2022

Conversation

@apbard
Copy link
Contributor

@apbard apbard commented Oct 6, 2022

Usage of relative imports in cpp files allows to not rely on folder structure

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 6, 2022
@vmoens vmoens changed the title Use relative imports for local c++ deps [Quality] Use relative imports for local c++ deps Oct 6, 2022
@vmoens vmoens added the quality code quality label Oct 6, 2022
@vmoens vmoens merged commit 35db6fe into pytorch:main Oct 6, 2022
@apbard apbard deleted the apbard-patch-1 branch October 7, 2022 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vmoens vmoens vmoens approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. quality code quality

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@apbard @vmoens @facebook-github-bot