Skip to content

Conversation

@nicolas-dufour
Copy link
Contributor

@nicolas-dufour nicolas-dufour commented Sep 26, 2022

Description

Allows to deactivate typechecks in envs

Motivation and Context

We want to be able to deactivates typechecks since it can block code execution when the dtype gets changes (ex autocast to float16)

Types of changes

What types of changes does your code introduce? Remove all that do not apply:

  • New feature (non-breaking change which adds core functionality)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide (required)
  • I have updated the tests accordingly (required for a bug fix or a new feature).

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 26, 2022
@vmoens vmoens added the enhancement New feature or request label Sep 26, 2022
Copy link
Collaborator

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vmoens vmoens merged commit b0982cc into pytorch:main Sep 26, 2022
@nicolas-dufour nicolas-dufour deleted the deactivate_type_checks branch September 26, 2022 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants