-
Notifications
You must be signed in to change notification settings - Fork 418
[BugFix] Add transform_observation_spec _R3MNet #443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BugFix] Add transform_observation_spec _R3MNet #443
Conversation
|
Hi @vmoens, I got the message for the workflow: Could you please approve this workflow? Thanks! |
4ff349a to
7da6421
Compare
vmoens
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, let's clean up the tests and land this!
…rate transform_observation_spec tests inside TestR3M test suite; 3) fix some errors
7da6421 to
ee03c05
Compare
Thanks for your comments! I have improved the code accordingly, rebased to the latest main branch, and update the branch. |
vmoens
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks!
Description
Define transform_observation_spec function in _R3MNet class
Add test cases
One test case TestR3MNet.test_r3mnet_transform_observation_spec is added. In the test, we set up these parameters
Then we compare the new observation_spec with the expected ones.
Motivation and Context
close #407
Types of changes
What types of changes does your code introduce? Remove all that do not apply:
Checklist