[ONNX] Support aten.stack for dynamo_export #99191
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/99191
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 67d19d1: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
| @@ -132,6 +132,7 @@ def aten_getitem(self, i): | |||
| "aten::softmax": ops.special.aten_special_softmax, | |||
| "aten::split": ops.core.aten_split, | |||
| "aten::sqrt": ops.core.aten_sqrt, | |||
| "aten::stack": ops.core.aten_stack, | |||
There was a problem hiding this comment.
@justinchuby iirc this op have been in torchlib for a while. Curious what is the updating routine for bringing in new supported ops in torchlib?
There was a problem hiding this comment.
I don’t think we have a routine for now. When we do dispatch it should become a discovery process
There was a problem hiding this comment.
For now they are just added as needed
There was a problem hiding this comment.
@justinchuby We could adopt fx exporter into test_op_consistency as model side check, like you brought up yesterday.
[ghstack-poisoned]
[ghstack-poisoned]
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Stack from ghstack (oldest at bottom):