[fx] Subgraph rewriter matching on attributes #98604
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/98604
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 FailuresAs of commit 02114b6: NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
andrewor14
approved these changes
Apr 7, 2023
SherlockNoMad
approved these changes
Apr 7, 2023
|
@pytorchbot merge -f "Failed test errors with 'The operation was canceled.' so I don't think it's my fault? sorry in advance if it is my fault" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
skotapati
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Apr 10, 2023
Fixes pytorch#68534 Similar to how submodules are added, if there already exists an attribute with the same name in `gm` as in `replacement`, the attribute value in `gm` will take precedence. Pull Request resolved: pytorch#98604 Approved by: https://github.com/andrewor14, https://github.com/SherlockNoMad
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #68534
Similar to how submodules are added, if there already exists an attribute with the same name in
gmas inreplacement, the attribute value ingmwill take precedence.