Skip to content

Conversation

mcr229
Copy link
Contributor

@mcr229 mcr229 commented Apr 7, 2023

Stack from ghstack (oldest at bottom):

Differential Revision: D44776230

@mcr229 mcr229 requested a review from jerryzh168 as a code owner April 7, 2023 03:04
@pytorch-bot pytorch-bot bot added the release notes: quantization release notes category label Apr 7, 2023
@pytorch-bot
Copy link

pytorch-bot bot commented Apr 7, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/98569

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Failures

As of commit 3dddf4e:

BROKEN TRUNK - The following jobs failed but were present on the merge base e943b12:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

mcr229 added a commit that referenced this pull request Apr 7, 2023
Differential Revision: [D44776230](https://our.internmc.facebook.com/intern/diff/D44776230/)

ghstack-source-id: 185387439
Pull Request resolved: #98569
Copy link
Contributor

@andrewor14 andrewor14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine for now since there's no easy way to override the default QConfig. In the future we should refactor the duplicate code. Can you add a TODO for this?

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Apr 7, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@facebook-github-bot facebook-github-bot deleted the gh/mcr229/31/head branch June 8, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged merging release notes: quantization release notes category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants