Skip to content

Add support for pin memory on custom device. #97621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add support for pin memory on custom device. #97621

wants to merge 1 commit into from

Conversation

donnyyou
Copy link
Contributor

Add support for pin memory on custom device.

@pytorch-bot pytorch-bot bot added the release notes: dataloader release notes category label Mar 26, 2023
@pytorch-bot
Copy link

pytorch-bot bot commented Mar 26, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/97621

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 321b845:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@donnyyou donnyyou force-pushed the extend_dataloader branch from f922754 to 097e546 Compare March 26, 2023 07:40
@donnyyou donnyyou force-pushed the extend_dataloader branch from 097e546 to 321b845 Compare March 26, 2023 08:16
@drisspg drisspg requested a review from NivekT March 27, 2023 16:25
@drisspg drisspg added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Mar 27, 2023
@donnyyou
Copy link
Contributor Author

@NivekT I give this PR to add support for pin memory on custom device. Would you please take a moment to review it?

NivekT
NivekT approved these changes Mar 29, 2023
View reviewed changes
Copy link
Contributor

@NivekT NivekT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for adding this.

@NivekT
Copy link
Contributor

NivekT commented Mar 29, 2023

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Mar 29, 2023
@NivekT NivekT added the topic: improvements topic category label Mar 29, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@ykddd ykddd mentioned this pull request Apr 13, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@NivekT NivekT NivekT approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: dataloader release notes category topic: improvements topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@donnyyou @NivekT @pytorchmergebot @pytorchbot @drisspg