-
Notifications
You must be signed in to change notification settings - Fork 25.2k
Resubmit _int_mm #96685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resubmit _int_mm #96685
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/96685
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 29cd01b: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
@cpuhrsch has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
This reverts commit 0a53c96.
test/test_decomp.py
Outdated
@@ -742,6 +742,9 @@ def all_aten_overloads(): | |||
# This is for operators that are only registered in some CI | |||
# configurations, so would cause the test to fail | |||
allow_list = {aten.get_gradients.default} | |||
# Skip check for _int_mm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ngimel - Is this what you had in mind in comment #95681 (comment) ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test asserts expected outcome on line 752, you should modify expected file (HasDecompTest.test_has_decomposition.expect
) to include _int_mm
(you can do it passing --accept
arg to the test, or manually).
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Avoids any changes to gemm_and_bias
cc @soumith @voznesenskym @penguinwu @anijain2305 @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @peterbell10 @desertfire