Skip to content

Conversation

cpuhrsch
Copy link
Contributor

@cpuhrsch cpuhrsch commented Mar 13, 2023

@pytorch-bot
Copy link

pytorch-bot bot commented Mar 13, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/96685

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 29cd01b:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@cpuhrsch cpuhrsch requested a review from ngimel March 13, 2023 21:39
@cpuhrsch cpuhrsch changed the title Undo changes to from _int_mm to gemm_and_bias Undo changes from _int_mm to gemm_and_bias Mar 14, 2023
@facebook-github-bot
Copy link
Contributor

@cpuhrsch has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@cpuhrsch cpuhrsch added the topic: not user facing topic category label Mar 16, 2023
@cpuhrsch cpuhrsch changed the title Undo changes from _int_mm to gemm_and_bias Resubmit _int_mm Mar 16, 2023
@@ -742,6 +742,9 @@ def all_aten_overloads():
# This is for operators that are only registered in some CI
# configurations, so would cause the test to fail
allow_list = {aten.get_gradients.default}
# Skip check for _int_mm
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ngimel - Is this what you had in mind in comment #95681 (comment) ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test asserts expected outcome on line 752, you should modify expected file (HasDecompTest.test_has_decomposition.expect) to include _int_mm (you can do it passing --accept arg to the test, or manually).

@cpuhrsch cpuhrsch added the ciflow/trunk Trigger trunk jobs on your pull request label Mar 23, 2023
@cpuhrsch
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants