Support randn_like() for NT #96528

jbschlosser · 2023-03-10T17:04:48Z

Stack from ghstack (oldest at bottom):

To satisfy an internal ask.

[ghstack-poisoned]

pytorch-bot · 2023-03-10T17:04:51Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/96528

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 2b4d3c2:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

jbschlosser · 2023-03-10T17:39:14Z

test/test_nestedtensor.py

@@ -499,13 +499,15 @@ def test_zero_(self):
            t.fill_(0.)
            self.assertEqual(nt_ub, t)

-    @parametrize("func", [torch.ones_like, torch.zeros_like],


Note: This currently passes, but I can imagine an alternative implementation of randn_like() for NT that doesn't have the property of "generating all random numbers at once -> gives same numbers as iteratively generating numbers matching underlying component sizes", and it could be argued this is no less correct. So I'm open to better forms of testing.

jbschlosser · 2023-03-10T21:51:06Z

@pytorchbot merge

pytorchmergebot · 2023-03-10T21:53:29Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2023-03-10T23:19:41Z

Merge failed

Reason: 1 jobs have failed, first few of them are: linux-binary-manywheel / manywheel-py3_8-cuda11_7-test / test

Details for Dev Infra team

Raised by workflow job

jbschlosser · 2023-03-13T15:13:19Z

@pytorchbot merge -f "spurious failures"

pytorchmergebot · 2023-03-13T15:15:48Z

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2023-03-13T15:15:59Z

Merge failed

Reason: Command git -C /home/runner/work/pytorch/pytorch cherry-pick -x 190bf26c3bab197ac287ccb4442bfed85c686ae7 returned non-zero exit code 1

Auto-merging aten/src/ATen/native/native_functions.yaml
Auto-merging docs/source/nested.rst
CONFLICT (content): Merge conflict in docs/source/nested.rst
Auto-merging test/test_nestedtensor.py
CONFLICT (content): Merge conflict in test/test_nestedtensor.py
error: could not apply 190bf26c3ba... Support randn_like() for NT
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

Details for Dev Infra team

Raised by workflow job

To satisfy an internal ask. [ghstack-poisoned]

jbschlosser · 2023-03-13T16:24:05Z

@pytorchbot merge

pytorchmergebot · 2023-03-13T16:27:11Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

To satisfy an internal ask. Pull Request resolved: #96528 Approved by: https://github.com/mikaylagawarecki, https://github.com/cpuhrsch ghstack-source-id: d6e4534

To satisfy an internal ask. Pull Request resolved: pytorch/pytorch#96528 Approved by: https://github.com/mikaylagawarecki, https://github.com/cpuhrsch

Support randn_like() for NT

bf54268

[ghstack-poisoned]

jbschlosser mentioned this pull request Mar 10, 2023

Support zeros_like() for NT #96527

Closed

jbschlosser mentioned this pull request Mar 10, 2023

Initial fake / meta tensor support for nested tensors #96354

Closed

github-actions bot requested review from albanD, antoniojkim, bdhirsh, Chillee, ezyang, miladm, SherlockNoMad, voznesenskym and wconstab March 10, 2023 17:05

jbschlosser requested review from drisspg, cpuhrsch and mikaylagawarecki and removed request for ezyang, miladm, voznesenskym, wconstab, Chillee, albanD, SherlockNoMad, bdhirsh and antoniojkim March 10, 2023 17:06

jbschlosser added release notes: nested tensor Changes that have a direct impact on nested tensors topic: improvements topic category labels Mar 10, 2023

jbschlosser commented Mar 10, 2023

View reviewed changes

mikaylagawarecki approved these changes Mar 10, 2023

View reviewed changes

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Mar 10, 2023

cpuhrsch approved these changes Mar 10, 2023

View reviewed changes

Update on "Support randn_like() for NT"

2b4d3c2

To satisfy an internal ask. [ghstack-poisoned]

pytorchmergebot added the Merged label Mar 13, 2023

pytorchmergebot closed this in 30d56dd Mar 13, 2023

zhaojuanmao added a commit that referenced this pull request Mar 13, 2023

Support randn_like() for NT (#96528)

6bff380

To satisfy an internal ask. Pull Request resolved: #96528 Approved by: https://github.com/mikaylagawarecki, https://github.com/cpuhrsch ghstack-source-id: d6e4534

cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 23, 2023

Support randn_like() for NT (#96528)

aef61d8

To satisfy an internal ask. Pull Request resolved: pytorch/pytorch#96528 Approved by: https://github.com/mikaylagawarecki, https://github.com/cpuhrsch

cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 27, 2023

Support randn_like() for NT (#96528)

635ee16

To satisfy an internal ask. Pull Request resolved: pytorch/pytorch#96528 Approved by: https://github.com/mikaylagawarecki, https://github.com/cpuhrsch

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Support randn_like() for NT #96528

Support randn_like() for NT #96528

Uh oh!

jbschlosser commented Mar 10, 2023 •

edited

Loading

Uh oh!

pytorch-bot bot commented Mar 10, 2023 •

edited

Loading

Uh oh!

jbschlosser Mar 10, 2023 •

edited

Loading

Uh oh!

jbschlosser commented Mar 10, 2023

Uh oh!

pytorchmergebot commented Mar 10, 2023

Uh oh!

pytorchmergebot commented Mar 10, 2023

Uh oh!

jbschlosser commented Mar 13, 2023

Uh oh!

pytorchmergebot commented Mar 13, 2023

Uh oh!

pytorchmergebot commented Mar 13, 2023

Uh oh!

jbschlosser commented Mar 13, 2023

Uh oh!

pytorchmergebot commented Mar 13, 2023

Uh oh!

Uh oh!

Support randn_like() for NT #96528

Support randn_like() for NT #96528

Uh oh!

Conversation

jbschlosser commented Mar 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Mar 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/96528

✅ No Failures

Uh oh!

jbschlosser Mar 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jbschlosser commented Mar 10, 2023

Uh oh!

pytorchmergebot commented Mar 10, 2023

Merge started

Uh oh!

pytorchmergebot commented Mar 10, 2023

Merge failed

Uh oh!

jbschlosser commented Mar 13, 2023

Uh oh!

pytorchmergebot commented Mar 13, 2023

Merge started

Uh oh!

pytorchmergebot commented Mar 13, 2023

Merge failed

Uh oh!

jbschlosser commented Mar 13, 2023

Uh oh!

pytorchmergebot commented Mar 13, 2023

Merge started

Uh oh!

Uh oh!

jbschlosser commented Mar 10, 2023 •

edited

Loading

pytorch-bot bot commented Mar 10, 2023 •

edited

Loading

jbschlosser Mar 10, 2023 •

edited

Loading