[dynamo 3.11] support prefix instructions MAKE_CELL, COPY_FREE_VARS, RETURN_GENERATOR, RESUME #96506
Conversation
…RETURN_GENERATOR, RESUME [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/96506
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 11f1159: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
…FREE_VARS, RETURN_GENERATOR, RESUME" cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire [ghstack-poisoned]
…FREE_VARS, RETURN_GENERATOR, RESUME" cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire [ghstack-poisoned]
…FREE_VARS, RETURN_GENERATOR, RESUME" cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire [ghstack-poisoned]
…FREE_VARS, RETURN_GENERATOR, RESUME" cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire [ghstack-poisoned]
…FREE_VARS, RETURN_GENERATOR, RESUME" cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire [ghstack-poisoned]
…FREE_VARS, RETURN_GENERATOR, RESUME" cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire [ghstack-poisoned]
…FREE_VARS, RETURN_GENERATOR, RESUME" cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire [ghstack-poisoned]
…FREE_VARS, RETURN_GENERATOR, RESUME" cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire [ghstack-poisoned]
…FREE_VARS, RETURN_GENERATOR, RESUME" cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire [ghstack-poisoned]
| return 0 | ||
| for inst in dis.get_instructions(code): | ||
| if inst.opname == "RESUME": | ||
| return inst.offset // 2 |
There was a problem hiding this comment.
Is the //2 ok here? All opcodes might not be of size 2 here?
There was a problem hiding this comment.
We follow the implementation of _co_firsttraceable in CPython (codeobject.c), which uses bytecode index (2 bytes), not instruction index.
| @@ -1600,6 +1605,19 @@ def BEFORE_WITH(self, inst): | |||
| self.push(exit) | |||
| self.push(ctx.enter(self)) | |||
|
|
|||
| def append_prefix_inst(self, inst): | |||
There was a problem hiding this comment.
Do we need to enforce the ordering of the inst in here? Or it should always be ok since we add things as we read the original frame?
There was a problem hiding this comment.
We add things as read in the original frame, and any instructions that jump necessarily come after the prefix, and they shouldn't jump to before the prefix.
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Stack from ghstack (oldest at bottom):
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames @soumith @anijain2305 @Xia-Weiwen @desertfire