add Half to cat fast path on CPU #96078
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/96078
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 90be642: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
Extend current fast path on `cat` with `Half`: for non-arithmetic Ops, simply do `Vec::load` and `Vec::store`. cc jgong5 XiaobingSuper sanchitintel ashokei jingxu10 [ghstack-poisoned]
Extend current fast path on `cat` with `Half`: for non-arithmetic Ops, simply do `Vec::load` and `Vec::store`. cc jgong5 XiaobingSuper sanchitintel ashokei jingxu10 [ghstack-poisoned]
Extend current fast path on `cat` with `Half`: for non-arithmetic Ops, simply do `Vec::load` and `Vec::store`. cc jgong5 XiaobingSuper sanchitintel ashokei jingxu10 [ghstack-poisoned]
Extend current fast path on `cat` with `Half`: for non-arithmetic Ops, simply do `Vec::load` and `Vec::store`. cc jgong5 XiaobingSuper sanchitintel ashokei jingxu10 [ghstack-poisoned]
Extend current fast path on `cat` with `Half`: for non-arithmetic Ops, simply do `Vec::load` and `Vec::store`. cc jgong5 XiaobingSuper sanchitintel ashokei jingxu10 [ghstack-poisoned]
|
@pytorchbot merge |
Merge failedReason: Approval needed from one of the following: |
|
@ezyang need core maintainer here. This one is very simple now, as Half has been added to the fast path, we can use |
|
With this sort of thing, it's nice to see the before after perf numbers too |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: This PR is too stale; the last push date was more than 3 days ago. Please rebase and try again. You can rebase and merge by leaving the following comment on this PR: Details for Dev Infra teamRaised by workflow job |
Extend current fast path on `cat` with `Half`: for non-arithmetic Ops, simply do `Vec::load` and `Vec::store`. cc jgong5 XiaobingSuper sanchitintel ashokei jingxu10 [ghstack-poisoned]
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Extend current fast path on `cat` with `Half`: for non-arithmetic Ops, simply do `Vec::load` and `Vec::store`. Pull Request resolved: pytorch#96078 Approved by: https://github.com/jgong5, https://github.com/ezyang
Stack from ghstack (oldest at bottom):
Extend current fast path on
catwithHalf: for non-arithmetic Ops, simply doVec::loadandVec::store.cc @jgong5 @XiaobingSuper @sanchitintel @ashokei @jingxu10