Skip to content

[ONNX] Preserve stacktrace info for decomp #95929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 13 commits into from
Closed

[ONNX] Preserve stacktrace info for decomp #95929

wants to merge 13 commits into from

Conversation

BowenBao
Copy link
Collaborator

@BowenBao BowenBao commented Mar 3, 2023 •
edited
Loading

@BowenBao BowenBao requested a review from abock as a code owner March 3, 2023 01:00
@BowenBao BowenBao mentioned this pull request Mar 3, 2023
Closed
@pytorch-bot pytorch-bot bot added the release notes: onnx torch.onnx related changes that should show up in the release notes label Mar 3, 2023
@BowenBao BowenBao mentioned this pull request Mar 3, 2023
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Mar 3, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/95929

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Failures

As of commit 968a688:

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This was referenced Mar 3, 2023
Closed
Closed
Closed
@BowenBao BowenBao mentioned this pull request Mar 3, 2023
Closed
@BowenBao BowenBao added topic: improvements topic category module: onnx Related to torch.onnx labels Mar 6, 2023
@BowenBao
Copy link
Collaborator Author

@pytorchbot merge -g

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Mar 10, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: linux-binary-manywheel / manywheel-py3_8-cuda11_7-test / test

Details for Dev Infra team Raised by workflow job

@BowenBao
Copy link
Collaborator Author

@pytorchbot merge -f "unrelated 'Could not find a version that satisfies the requirement pytorch-triton==2.1.0+b8b470bc59' failure"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 12, 2023
@BowenBao @cyyever
[ONNX] Preserve stacktrace info for decomp (#95929)
ecff8fd 
Pull Request resolved: pytorch/pytorch#95929
Approved by: https://github.com/justinchuby
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 14, 2023
@BowenBao @cyyever
[ONNX] Preserve stacktrace info for decomp (#95929)
6e317ce 
Pull Request resolved: pytorch/pytorch#95929
Approved by: https://github.com/justinchuby
@facebook-github-bot facebook-github-bot deleted the gh/BowenBao/208/head branch June 8, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinchuby justinchuby justinchuby approved these changes

@abock abock Awaiting requested review from abock

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged module: onnx Related to torch.onnx open source release notes: onnx torch.onnx related changes that should show up in the release notes topic: improvements topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BowenBao @pytorchmergebot @justinchuby @pytorchbot