[dynamo] handle 3.13.0 dict watcher bug #138284

williamwen42 · 2024-10-17T23:54:48Z

Stack from ghstack (oldest at bottom):

python/cpython#116115 introduced a bug (python/cpython#125608) where changing the attributes of an object may not fire the dict watchers registered to the object's __dict__. It has been fixed by python/cpython#125611 but will only be in 3.13.1+.

This PR disables the dict watcher guard shortcut for __dict__s on 3.13.0 and warns the user to try using 3.13.1+ instead. We also added a simple test to check for this functionality in the future.

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames @rec

[ghstack-poisoned]

pytorch-bot · 2024-10-17T23:54:51Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/138284

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit e9f87a2 with merge base d2ec289 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

ghstack-source-id: 9b94a96 Pull Request resolved: #138284

anijain2305 · 2024-10-18T23:00:26Z

torch/_dynamo/guards.py

+        # fixed by https://github.com/python/cpython/pull/125611), we cannot take
+        # advantage of __dict__ versions to speed up guard checks.
+        if sys.version_info >= (3, 13) and sys.version_info < (3, 13, 1):
+            warnings.warn(


The warnings module should warn once by default.

Seems like it should be a RuntimeWarning type warning instead of a UserWarning. Unless there is a better type?

python/cpython#116115 introduced a bug (python/cpython#125608) where changing the attributes of an object may not fire the dict watchers registered to the object's `__dict__`. It has been fixed by python/cpython#125611 but will only be in 3.13.1+. This PR disables the dict watcher guard shortcut for `__dict__`s on 3.13.0 and warns the user to try using 3.13.1+ instead. We also added a simple test to check for this functionality in the future. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames rec [ghstack-poisoned]

ghstack-source-id: 0e6eb5f Pull Request resolved: #138284

williamwen42 · 2024-10-23T17:35:46Z

@pytorchbot merge

pytorchmergebot · 2024-10-23T17:37:44Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2024-10-23T17:38:03Z

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Lint / lintrunner-noclang / linux-job

Dig deeper by viewing the failures on hud

Details for Dev Infra team

Raised by workflow job

Failing merge rule: Core Maintainers

python/cpython#116115 introduced a bug (python/cpython#125608) where changing the attributes of an object may not fire the dict watchers registered to the object's `__dict__`. It has been fixed by python/cpython#125611 but will only be in 3.13.1+. This PR disables the dict watcher guard shortcut for `__dict__`s on 3.13.0 and warns the user to try using 3.13.1+ instead. We also added a simple test to check for this functionality in the future. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames rec [ghstack-poisoned]

ghstack-source-id: 9df5967 Pull Request resolved: #138284

williamwen42 · 2024-10-26T00:57:34Z

@pytorchbot merge

pytorchmergebot · 2024-10-26T00:59:17Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2024-10-26T00:59:51Z

Merge failed

Reason: 15 jobs have failed, first few of them are: inductor / linux-jammy-cpu-py3.9-gcc11-inductor / test (cpu_inductor_torchbench, 2, 2, linux.12xlarge), inductor / linux-jammy-cpu-py3.9-gcc11-inductor / test (cpu_inductor_freezing_torchbench, 2, 2, linux.12xlarge), inductor / linux-jammy-cpu-py3.9-gcc11-inductor / test (cpu_inductor_amp_freezing_torchbench, 2, 2, linux.16xlarge.spr), inductor / linux-jammy-cpu-py3.9-gcc11-inductor / test (dynamic_cpu_inductor_torchbench, 2, 2, linux.12xlarge), inductor / linux-jammy-cpu-py3.9-gcc11-inductor / test (cpu_aot_inductor_freezing_torchbench, 2, 2, linux.12xlarge)

Details for Dev Infra team

Raised by workflow job

williamwen42 · 2024-10-28T17:39:04Z

@pytorchbot merge

pytorchmergebot · 2024-10-28T17:40:51Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2024-10-28T17:41:25Z

Merge failed

Reason: 15 jobs have failed, first few of them are: inductor / linux-jammy-cpu-py3.9-gcc11-inductor / test (cpu_inductor_torchbench, 2, 2, linux.12xlarge), inductor / linux-jammy-cpu-py3.9-gcc11-inductor / test (cpu_inductor_freezing_torchbench, 2, 2, linux.12xlarge), inductor / linux-jammy-cpu-py3.9-gcc11-inductor / test (cpu_inductor_amp_freezing_torchbench, 2, 2, linux.16xlarge.spr), inductor / linux-jammy-cpu-py3.9-gcc11-inductor / test (dynamic_cpu_inductor_torchbench, 2, 2, linux.12xlarge), inductor / linux-jammy-cpu-py3.9-gcc11-inductor / test (cpu_aot_inductor_freezing_torchbench, 2, 2, linux.12xlarge)

Details for Dev Infra team

Raised by workflow job

williamwen42 · 2024-10-28T17:42:04Z

@pytorchbot rebase

pytorchmergebot · 2024-10-28T17:43:31Z

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

[ghstack-poisoned]

pytorchmergebot · 2024-10-28T17:43:46Z

Successfully rebased gh/williamwen42/150/orig onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/138284)

ghstack-source-id: a12905b Pull Request resolved: #138284

williamwen42 · 2024-10-28T20:37:03Z

@pytorchbot merge

pytorchmergebot · 2024-10-28T20:38:44Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

python/cpython#116115 introduced a bug (python/cpython#125608) where changing the attributes of an object may not fire the dict watchers registered to the object's `__dict__`. It has been fixed by python/cpython#125611 but will only be in 3.13.1+. This PR disables the dict watcher guard shortcut for `__dict__`s on 3.13.0 and warns the user to try using 3.13.1+ instead. We also added a simple test to check for this functionality in the future. Pull Request resolved: pytorch#138284 Approved by: https://github.com/jansel ghstack dependencies: pytorch#138030

[dynamo] handle 3.13.0 __dict__ watcher bug

495ed90

[ghstack-poisoned]

williamwen42 mentioned this pull request Oct 17, 2024

[dynamo] add some cpython debugging methods #138030

Closed

pytorch-bot bot added ciflow/inductor module: dynamo labels Oct 17, 2024

williamwen42 added a commit that referenced this pull request Oct 17, 2024

[dynamo] handle 3.13.0 __dict__ watcher bug

c69b560

ghstack-source-id: 9b94a96 Pull Request resolved: #138284

williamwen42 added the topic: not user facing topic category label Oct 17, 2024

williamwen42 requested review from anijain2305 and jansel and removed request for jansel October 17, 2024 23:58

jansel approved these changes Oct 18, 2024

View reviewed changes

anijain2305 reviewed Oct 18, 2024

View reviewed changes

williamwen42 added a commit that referenced this pull request Oct 22, 2024

[dynamo] handle 3.13.0 __dict__ watcher bug

2cf1a50

ghstack-source-id: 0e6eb5f Pull Request resolved: #138284

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 23, 2024

pytorchmergebot added the merging label Oct 23, 2024

pytorchmergebot removed the merging label Oct 23, 2024

williamwen42 added a commit that referenced this pull request Oct 25, 2024

[dynamo] handle 3.13.0 __dict__ watcher bug

b64d299

ghstack-source-id: 9df5967 Pull Request resolved: #138284

pytorchmergebot added the merging label Oct 26, 2024

pytorchmergebot removed the merging label Oct 26, 2024

pytorchmergebot added the merging label Oct 28, 2024

pytorchmergebot removed the merging label Oct 28, 2024

Update

e9f87a2

[ghstack-poisoned]

pytorchmergebot pushed a commit that referenced this pull request Oct 28, 2024

[dynamo] handle 3.13.0 __dict__ watcher bug

1d65c23

ghstack-source-id: a12905b Pull Request resolved: #138284

pytorchmergebot added the merging label Oct 28, 2024

pytorchmergebot added the Merged label Oct 28, 2024

pytorchmergebot closed this in 904816d Oct 28, 2024

pytorchmergebot removed the merging label Oct 28, 2024

github-actions bot deleted the gh/williamwen42/150/head branch November 28, 2024 02:15

[dynamo] handle 3.13.0 __dict__ watcher bug #138284

[dynamo] handle 3.13.0 __dict__ watcher bug #138284

Uh oh!

Conversation

williamwen42 commented Oct 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Oct 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/138284

✅ No Failures

Uh oh!

anijain2305 Oct 18, 2024

Choose a reason for hiding this comment

Uh oh!

williamwen42 Oct 18, 2024

Choose a reason for hiding this comment

Uh oh!

Skylion007 Oct 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

williamwen42 commented Oct 23, 2024

Uh oh!

pytorchmergebot commented Oct 23, 2024

Merge started

Uh oh!

pytorchmergebot commented Oct 23, 2024

Merge failed

Uh oh!

williamwen42 commented Oct 26, 2024

Uh oh!

pytorchmergebot commented Oct 26, 2024

Merge started

Uh oh!

pytorchmergebot commented Oct 26, 2024

Merge failed

Uh oh!

williamwen42 commented Oct 28, 2024

Uh oh!

pytorchmergebot commented Oct 28, 2024

Merge started

Uh oh!

pytorchmergebot commented Oct 28, 2024

Merge failed

Uh oh!

williamwen42 commented Oct 28, 2024

Uh oh!

pytorchmergebot commented Oct 28, 2024

Uh oh!

pytorchmergebot commented Oct 28, 2024

Uh oh!

williamwen42 commented Oct 28, 2024

Uh oh!

pytorchmergebot commented Oct 28, 2024

Merge started

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

[dynamo] handle 3.13.0 dict watcher bug #138284

[dynamo] handle 3.13.0 dict watcher bug #138284

williamwen42 commented Oct 17, 2024 •

edited

Loading

pytorch-bot bot commented Oct 17, 2024 •

edited

Loading

Skylion007 Oct 19, 2024 •

edited

Loading