[ONNX] Fix diagnostic log and add unittest #107158
Closed
+31
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/107158
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 538e202: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
titaiwangms
approved these changes
Aug 14, 2023
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorchmergebot
pushed a commit
that referenced
this pull request
Aug 15, 2023
#107165) Allows overriding the `Diagnostic` type for DiagnosticContext and enable type checking. Pull Request resolved: #107165 Approved by: https://github.com/justinchuby, https://github.com/titaiwangms ghstack dependencies: #106741, #107158
pytorchmergebot
pushed a commit
that referenced
this pull request
Aug 15, 2023
To not conflict with potential existing workaround or solution outside of exporter. Latest huggingface/transformers main (>4.31) patches PyTorch PyTree with support over `ModelOutput` class. `_PyTreeExtensionContext` is kept to support prior versions of transformers. Pull Request resolved: #107245 Approved by: https://github.com/titaiwangms ghstack dependencies: #106741, #107158, #107165
summerdo
pushed a commit
to summerdo/pytorch
that referenced
this pull request
Aug 17, 2023
As title. Previously message was formatted but mistakenly not logged. Pull Request resolved: pytorch#107158 Approved by: https://github.com/titaiwangms ghstack dependencies: pytorch#106741
summerdo
pushed a commit
to summerdo/pytorch
that referenced
this pull request
Aug 17, 2023
pytorch#107165) Allows overriding the `Diagnostic` type for DiagnosticContext and enable type checking. Pull Request resolved: pytorch#107165 Approved by: https://github.com/justinchuby, https://github.com/titaiwangms ghstack dependencies: pytorch#106741, pytorch#107158
summerdo
pushed a commit
to summerdo/pytorch
that referenced
this pull request
Aug 17, 2023
…107245) To not conflict with potential existing workaround or solution outside of exporter. Latest huggingface/transformers main (>4.31) patches PyTorch PyTree with support over `ModelOutput` class. `_PyTreeExtensionContext` is kept to support prior versions of transformers. Pull Request resolved: pytorch#107245 Approved by: https://github.com/titaiwangms ghstack dependencies: pytorch#106741, pytorch#107158, pytorch#107165
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
As title. Previously message was formatted but mistakenly not logged.