[functorch] fix dynamo support for functorch.grad #106610
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/106610
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 3 PendingAs of commit f4c9b27: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
zou3519
reviewed
Aug 7, 2023
| @@ -194,7 +195,7 @@ def _find_torch_objects(module): | |||
| if isinstance(obj, torch._ops.HigherOrderOperator): | |||
| continue | |||
| # We want to trace through `grad` | |||
| if obj is torch.func.grad: | |||
| if obj in (torch.func.grad, deprecated_func.grad): | |||
There was a problem hiding this comment.
Oh no. Can you do the same for vmap in the other PR?
zou3519
approved these changes
Aug 7, 2023
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Cyril-Anto
pushed a commit
to Cyril-Anto/pytorch
that referenced
this pull request
Aug 17, 2023
Ref: pytorch#106475 (comment) Pull Request resolved: pytorch#106610 Approved by: https://github.com/zou3519
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #106475 (comment)
cc @voznesenskym @penguinwu @anijain2305 @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @aakhundov