Handle Rational divisors in FloorDiv.
#106644
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow-up: #101173 This PR fixes the bug presented in #101173 by creating a special case for `sympy.Rational` divisors, inside `FloorDiv` evaluation. In summary: ```python FloorDiv(a, Rational(1, b)) a * b ``` Besides that, this PR also does 2 other things: - Replaces the use of the old `sympy.Mod` by the internal `Mod` (there were a few places that were still looking for the SymPy one) - Introduces debugging logs to the translation validator. These can be seen by setting the environment variable: `TORCH_LOGS=+torch.fx.experimental.validator` [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/106644
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit a0b0050: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Aug 4, 2023
ezyang
approved these changes
Aug 5, 2023
…le `Rational` divisors in `FloorDiv`." Follow-up: #101173 This PR fixes the bug presented in #101173 by creating a special case for `sympy.Rational` divisors, inside `FloorDiv` evaluation. In summary: ```python FloorDiv(a, Rational(1, b)) a * b ``` Besides that, this PR also does 2 other things: - Replaces the use of the old `sympy.Mod` by the internal `Mod` (there were a few places that were still looking for the SymPy one) - Introduces debugging logs to the translation validator. These can be seen by setting the environment variable: `TORCH_LOGS=+torch.fx.experimental.validator` [ghstack-poisoned]
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: PR #106643 has not been reviewed yet |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Cyril-Anto
pushed a commit
to Cyril-Anto/pytorch
that referenced
this pull request
Aug 17, 2023
Follow-up: pytorch#101173 This PR fixes the bug presented in pytorch#101173 by creating a special case for `sympy.Rational` divisors, inside `FloorDiv` evaluation. In summary: ```python FloorDiv(a, Rational(1, b)) a * b ``` Besides that, this PR also does 2 other things: - Replaces the use of the old `sympy.Mod` by the internal `Mod` (there were a few places that were still looking for the SymPy one) - Introduces debugging logs to the translation validator. These can be seen by setting the environment variable: `TORCH_LOGS=+torch.fx.experimental.validator` Pull Request resolved: pytorch#106644 Approved by: https://github.com/ezyang ghstack dependencies: pytorch#106643
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Rationaldivisors inFloorDiv. #106644Follow-up: #101173
This PR fixes the bug presented in #101173 by creating a special case for
sympy.Rationaldivisors, inside
FloorDivevaluation. In summary:Besides that, this PR also does 2 other things:
Replaces the use of the old
sympy.Modby the internalMod(there were a few placesthat were still looking for the SymPy one)
Introduces debugging logs to the translation validator. These can be seen by setting the
environment variable:
TORCH_LOGS=+torch.fx.experimental.validator