Skip to content

Conversation

janeyx99
Copy link
Contributor

@janeyx99 janeyx99 commented Jul 19, 2023

[ghstack-poisoned]
@janeyx99 janeyx99 requested review from mruberry and ngimel as code owners July 19, 2023 21:40
@pytorch-bot
Copy link

pytorch-bot bot commented Jul 19, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/105607

Note: Links to docs will display an error until the docs builds have been completed.

✅ 3 Unrelated Failures

As of commit 1a4bfe9:

UNSTABLE - The following jobs failed but were likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@github-actions github-actions bot added the module: cpu CPU specific problem (e.g., perf, algorithm) label Jul 19, 2023
cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10

[ghstack-poisoned]
cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10

[ghstack-poisoned]
janeyx99 added a commit that referenced this pull request Jul 20, 2023
ghstack-source-id: 54cf1d8
Pull Request resolved: #105607
@janeyx99 janeyx99 requested a review from albanD July 20, 2023 16:22
@janeyx99 janeyx99 added topic: improvements topic category release notes: linalg_frontend release notes category ciflow/trunk Trigger trunk jobs on your pull request labels Jul 20, 2023
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10

[ghstack-poisoned]
@janeyx99 janeyx99 requested a review from kulinseth as a code owner July 21, 2023 17:03
janeyx99 added a commit that referenced this pull request Jul 21, 2023
ghstack-source-id: fb1b7dc
Pull Request resolved: #105607
@janeyx99
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@@ -10471,7 +10471,7 @@ class TestConsistency(TestCaseMPS):
'nn.functional.huber_loss',
'true_divide', 'kron',
'gradient', 'var', 'std', 'ldexp',
'linalg.vector_norm',
'linalg.vector_norm', 'lerp',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kulinseth to put under your radar!

@facebook-github-bot facebook-github-bot deleted the gh/janeyx99/73/head branch July 25, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged module: cpu CPU specific problem (e.g., perf, algorithm) release notes: linalg_frontend release notes category topic: improvements topic category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants