[quant][pt2] Fix no conv bias in convert QAT #103298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

andrewor14 wants to merge 1 commit into pytorch:main from andrewor14:export-D46382819

Contributor

andrewor14 commented Jun 9, 2023

Summary:
Previously, the QAT pattern for conv + bn with no conv
bias was not actually replaced in convert. This commit adds an
extra pattern in the convert path for this case and the numerics
now match FX's.

Test Plan: python test/test_quantization.py TestQuantizePT2E.test_prepare_qat_conv_bn_fusion_no_conv_bias

Reviewed By: jerryzh168

Differential Revision: D46382819

andrewor14 requested a review from jerryzh168 as a code owner

June 9, 2023 03:19

pytorch-bot bot commented Jun 9, 2023 •

edited

Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/103298

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ 3 Unrelated Failures

As of commit 39a168a:

UNSTABLE - The following jobs failed but were likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot bot added the release notes: quantization label

facebook-github-bot added the fb-exported label

Contributor

facebook-github-bot commented Jun 9, 2023

This pull request was exported from Phabricator. Differential Revision: D46382819

andrewor14 force-pushed the export-D46382819 branch from 75cb40c to 27fd5cc Compare

June 9, 2023 15:16

Contributor

facebook-github-bot commented Jun 9, 2023

This pull request was exported from Phabricator. Differential Revision: D46382819

andrewor14 force-pushed the export-D46382819 branch from 27fd5cc to 1f69429 Compare

June 9, 2023 15:26

Contributor

facebook-github-bot commented Jun 9, 2023

This pull request was exported from Phabricator. Differential Revision: D46382819

andrewor14 force-pushed the export-D46382819 branch from 1f69429 to e59f12b Compare

June 12, 2023 17:07

Contributor

facebook-github-bot commented Jun 12, 2023

This pull request was exported from Phabricator. Differential Revision: D46382819

andrewor14 force-pushed the export-D46382819 branch from e59f12b to 433f139 Compare

June 12, 2023 17:16

Contributor

facebook-github-bot commented Jun 12, 2023

This pull request was exported from Phabricator. Differential Revision: D46382819

andrewor14 force-pushed the export-D46382819 branch from 433f139 to 4b9bd1b Compare

June 13, 2023 15:57

Contributor

facebook-github-bot commented Jun 13, 2023

This pull request was exported from Phabricator. Differential Revision: D46382819

andrewor14 force-pushed the export-D46382819 branch from 4b9bd1b to 8fda2f2 Compare

June 13, 2023 16:09

Contributor

facebook-github-bot commented Jun 13, 2023

This pull request was exported from Phabricator. Differential Revision: D46382819

jerryzh168 approved these changes

View reviewed changes

andrewor14 force-pushed the export-D46382819 branch from 8fda2f2 to f5a8873 Compare

June 13, 2023 20:19

Contributor

facebook-github-bot commented Jun 13, 2023

This pull request was exported from Phabricator. Differential Revision: D46382819

andrewor14 force-pushed the export-D46382819 branch from f5a8873 to 7e442bb Compare

June 13, 2023 20:29

Contributor

facebook-github-bot commented Jun 13, 2023

This pull request was exported from Phabricator. Differential Revision: D46382819

Contributor

facebook-github-bot commented Jun 14, 2023

This pull request was exported from Phabricator. Differential Revision: D46382819

andrewor14 force-pushed the export-D46382819 branch from 6bdab7e to 1be2225 Compare

June 14, 2023 17:57

Contributor

facebook-github-bot commented Jun 14, 2023

This pull request was exported from Phabricator. Differential Revision: D46382819

andrewor14 force-pushed the export-D46382819 branch from 1be2225 to 003cead Compare

June 14, 2023 20:19

Contributor

facebook-github-bot commented Jun 14, 2023

This pull request was exported from Phabricator. Differential Revision: D46382819

andrewor14 force-pushed the export-D46382819 branch from 003cead to 1deb094 Compare

June 14, 2023 20:27

Contributor

facebook-github-bot commented Jun 14, 2023

This pull request was exported from Phabricator. Differential Revision: D46382819

andrewor14 force-pushed the export-D46382819 branch from 1deb094 to 813f44b Compare

June 14, 2023 20:37

Contributor

facebook-github-bot commented Jun 14, 2023

This pull request was exported from Phabricator. Differential Revision: D46382819

andrewor14 force-pushed the export-D46382819 branch from 813f44b to e63c36e Compare

June 14, 2023 20:48

Contributor

facebook-github-bot commented Jun 14, 2023

This pull request was exported from Phabricator. Differential Revision: D46382819

andrewor14 force-pushed the export-D46382819 branch from e63c36e to aaae1e1 Compare

June 15, 2023 15:43

Contributor

facebook-github-bot commented Jun 15, 2023

This pull request was exported from Phabricator. Differential Revision: D46382819


          [quant][pt2] Fix no conv bias in convert QAT (pytorch#103298)

39a168a

Summary:
Pull Request resolved: pytorch#103298

Previously, the QAT pattern for conv + bn with no conv
bias was not actually replaced in convert. This commit adds an
extra pattern in the convert path for this case and the numerics
now match FX's.

Test Plan: python test/test_quantization.py TestQuantizePT2E.test_prepare_qat_conv_bn_fusion_no_conv_bias

Reviewed By: jerryzh168

Differential Revision: D46382819

fbshipit-source-id: 9aac36c7cd873b08a9344de2853aca9126530066

andrewor14 force-pushed the export-D46382819 branch from aaae1e1 to 39a168a Compare

June 15, 2023 15:54

Contributor

facebook-github-bot commented Jun 15, 2023

This pull request was exported from Phabricator. Differential Revision: D46382819

Contributor

facebook-github-bot commented Jun 16, 2023

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

pytorch-bot bot added the ciflow/trunk label

pytorchmergebot added the merging label

Collaborator

pytorchmergebot commented Jun 16, 2023

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot added Merged and removed merging labels

pytorchmergebot closed this in

dad29f9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk fb-exported Merged release notes: quantization