Skip to content

Conversation

titaiwangms
Copy link
Collaborator

@titaiwangms titaiwangms commented Jun 6, 2023

@pytorch-bot
Copy link

pytorch-bot bot commented Jun 6, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/103061

Note: Links to docs will display an error until the docs builds have been completed.

✅ 3 Unrelated Failures

As of commit 73f11dd:

UNSTABLE - The following jobs failed but were likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added release notes: onnx torch.onnx related changes that should show up in the release notes labels Jun 6, 2023
@titaiwangms titaiwangms added topic: new features topic category module: onnx Related to torch.onnx labels Jun 6, 2023
@titaiwangms titaiwangms added the ciflow/trunk Trigger trunk jobs on your pull request label Jun 7, 2023
@titaiwangms
Copy link
Collaborator Author

@BowenBao PTAL

@titaiwangms
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: HTTP Error 403: rate limit exceeded

Details for Dev Infra team Raised by workflow job

@titaiwangms
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: HTTP Error 403: rate limit exceeded

Details for Dev Infra team Raised by workflow job

@titaiwangms
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@titaiwangms
Copy link
Collaborator Author

titaiwangms commented Jun 14, 2023

@BowenBao @justinchuby Do you guys know why CI fails? I have rebased couple times, but it seems this PR makes the test fail...

Looks like some sort of pip install issue with

2023-06-13T23:38:03.9703008Z no such option: --install-option

I wonder if it's related to onnx-script version bump.

@titaiwangms
Copy link
Collaborator Author

Looks like a pip issue needed to be fixed on CI machine:

Previous PRs CI log:

WARNING: Implying --no-binary=:all: due to the presence of --build-option / --global-option / --install-option. Consider using --config-settings for more flexibility.
DEPRECATION: --install-option is deprecated because it forces pip to use the 'setup.py install' command which is itself deprecated. pip 23.1 will enforce this behaviour change. A possible replacement is to use --config-settings. Discussion can be found at https://github.com/pypa/pip/issues/11358
DEPRECATION: --no-binary currently disables reading from the cache of locally built wheels. In the future --no-binary will not influence the wheel cache. pip 23.1 will enforce this behaviour change. A possible replacement is to use the --no-cache-dir option. You can use the flag --use-feature=no-binary-enable-wheel-cache to test the upcoming behaviour. Discussion can be found at https://github.com/pypa/pip/issues/11453

@titaiwangms
Copy link
Collaborator Author

titaiwangms commented Jun 14, 2023

@huydhn Could you help look into this CI failure?
It seems that the pip version doesn't allow --install-option on CI machine.

pip install -e . --install-option="--cudatests"

in .ci/pytorch/common_utils.sh

@BowenBao
Copy link
Collaborator

Same observation, strange though, I thought pip version should be consistent as it is controlled by the docker image.

Triggered a rerun of the failed test.

@titaiwangms
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@huydhn
Copy link
Contributor

huydhn commented Jun 15, 2023

@huydhn Could you help look into this CI failure? It seems that the pip version doesn't allow --install-option on CI machine.

pip install -e . --install-option="--cudatests"

in .ci/pytorch/common_utils.sh

Sorry that I missed your message. I also stumped upon this issue yesterday and had created an issue for that on multipy pytorch/multipy#322. In the meantime, I have mark this job as unstable #103654, so you can safely ignore the failure and merge the change as usual.

The ASAN docker build failure looks flaky, so I will retry it.

@titaiwangms
Copy link
Collaborator Author

@huydhn Could you help look into this CI failure? It seems that the pip version doesn't allow --install-option on CI machine.

pip install -e . --install-option="--cudatests"

in .ci/pytorch/common_utils.sh

Sorry that I missed your message. I also stumped upon this issue yesterday and had created an issue for that on multipy pytorch/multipy#322. In the meantime, I have mark this job as unstable #103654, so you can safely ignore the failure and merge the change as usual.

The ASAN docker build failure looks flaky, so I will retry it.

Thanks!!

@titaiwangms
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@facebook-github-bot facebook-github-bot deleted the gh/titaiwangms/27/head branch June 19, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged module: onnx Related to torch.onnx open source release notes: onnx torch.onnx related changes that should show up in the release notes topic: new features topic category
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants