Skip to content

[quant][pt2e] Add support for SharedQuantizationSpec #102184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[quant][pt2e] Add support for SharedQuantizationSpec #102184

wants to merge 1 commit into from

Conversation

jerryzh168
Copy link
Contributor

Summary:
This PR adds support for SharedQuantizationSpec, it's used to express the sharing between
two Tensors in the prepared graph, the Tensor will either be input of some node (expressed as a Tuple of fx nodes) or
output of some node (expressed as an fx Node)

Test Plan:

buck2 test mode/opt caffe2/test:quantization_pt2e -- 'caffe2/test:quantization_pt2e'
buck2 test mode/opt caffe2/test:quantization_pt2e -- --exact 'caffe2/test:quantization_pt2e - test_resnet18_with_quantizer_api (quantization.pt2e.test_quantize_pt2e.TestQuantizePT2EModels)'

Differential Revision: D46043026

@pytorch-bot
Copy link

pytorch-bot bot commented May 24, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/102184

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 475f45f:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: quantization release notes category label May 24, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D46043026

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D46043026

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D46043026

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D46043026

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D46043026

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D46043026

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D46043026

@jerryzh168 @facebook-github-bot
[quant][pt2e] Add support for SharedQuantizationSpec (pytorch#102184)
475f45f 
Summary:
Pull Request resolved: pytorch#102184

This PR adds support for SharedQuantizationSpec, it's used to express the sharing between
two Tensors in the prepared graph, the Tensor will either be input of some node (expressed as a Tuple of fx nodes) or
output of some node (expressed as an fx Node)

Test Plan:
```
buck2 test mode/opt caffe2/test:quantization_pt2e -- 'caffe2/test:quantization_pt2e'
buck2 test mode/opt caffe2/test:quantization_pt2e -- --exact 'caffe2/test:quantization_pt2e - test_resnet18_with_quantizer_api (quantization.pt2e.test_quantize_pt2e.TestQuantizePT2EModels)'
```

Reviewed By: kimishpatel

Differential Revision: D46043026

fbshipit-source-id: f284c28b1ea123d301cd9b87f86ddcf8781bf128
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D46043026

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label May 25, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@leslie-fang-intel leslie-fang-intel mentioned this pull request May 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimishpatel kimishpatel kimishpatel approved these changes

@leslie-fang-intel leslie-fang-intel leslie-fang-intel approved these changes

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged release notes: quantization release notes category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jerryzh168 @facebook-github-bot @pytorchmergebot @kimishpatel @leslie-fang-intel