Skip to content

Conversation

titaiwangms
Copy link
Collaborator

@titaiwangms titaiwangms commented May 18, 2023

Stack from ghstack (oldest at bottom):

Support aten::broadcast as the way we support on aten::expand.

Fix #92678 #101768

@pytorch-bot
Copy link

pytorch-bot bot commented May 18, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/101833

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 02a5d65:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: onnx torch.onnx related changes that should show up in the release notes label May 18, 2023
titaiwangms added a commit that referenced this pull request May 18, 2023
ghstack-source-id: c4c76d6
Pull Request resolved: #101833
@titaiwangms titaiwangms added module: onnx Related to torch.onnx topic: new features topic category labels May 18, 2023
@titaiwangms titaiwangms added the ciflow/trunk Trigger trunk jobs on your pull request label May 19, 2023
Copy link
Collaborator

@thiagocrepaldi thiagocrepaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a unit test that uses this op?

@titaiwangms
Copy link
Collaborator Author

can you add a unit test that uses this op?

That's in test_op_consistency.py .

@titaiwangms
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@facebook-github-bot facebook-github-bot deleted the gh/titaiwangms/20/head branch June 8, 2023 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged module: onnx Related to torch.onnx open source release notes: onnx torch.onnx related changes that should show up in the release notes topic: new features topic category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UnsupportedOperatorError: Exporting the operator 'aten::broadcast_to' to ONNX opset version 14 is not supported.
4 participants