Skip to content

[MPS] Add support for MPSProfiler Python bindings #101002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[MPS] Add support for MPSProfiler Python bindings #101002

wants to merge 1 commit into from

Conversation

razarmehr
Copy link
Collaborator

  • Added torch.mps.profiler.[start() and stop()] APIs with RST documentation
  • Added test case in test_mps

@razarmehr razarmehr added ciflow/trunk Trigger trunk jobs on your pull request release notes: mps Release notes category ciflow/mps Run MPS tests (subset of trunk) labels May 9, 2023
@pytorch-bot
Copy link

pytorch-bot bot commented May 9, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/101002

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 42a2765:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

malfet
malfet approved these changes May 9, 2023
View reviewed changes
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok, but please add at least one test for profile context manager

@razarmehr
Copy link
Collaborator Author

Looks ok, but please add at least one test for profile context manager

Thanks for the review. I'll try to find a way for verification and will update the PR (if I find any).

@razarmehr
Copy link
Collaborator Author

For the verification test case, I'll send another PR to check if tracing is enabled using os_signpost_enabled() method.

@razarmehr razarmehr force-pushed the MPS_ProfilerBindings branch 2 times, most recently from 3240428 to cb77bec Compare May 10, 2023 16:50
@razarmehr
[MPS] Add support for MPSProfiler Python bindings
42a2765 
- Added torch.mps.profiler.[start() and stop()] APIs with RST documentation
- Added test case in test_mps
@razarmehr razarmehr force-pushed the MPS_ProfilerBindings branch from cb77bec to 42a2765 Compare May 11, 2023 20:20
@razarmehr
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malfet malfet malfet approved these changes

@kulinseth kulinseth Awaiting requested review from kulinseth kulinseth is a code owner

@albanD albanD Awaiting requested review from albanD

@DenisVieriu97 DenisVieriu97 Awaiting requested review from DenisVieriu97

Assignees
No one assigned
Labels
ciflow/mps Run MPS tests (subset of trunk) ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: mps Release notes category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@razarmehr @pytorchmergebot @malfet @pytorchbot