Skip to content

Remove outdated skip conditons on tensor dtype tests #164917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Remove outdated skip conditons on tensor dtype tests #164917

wants to merge 1 commit into from

Conversation

cyyever
Copy link
Collaborator

@cyyever cyyever commented Oct 8, 2025 •
edited
Loading

Enables PPC and s390x on float_to_int_conversion tests.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Oct 8, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/164917

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 3 New Failures

As of commit bb1051e with merge base 1927783 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Oct 8, 2025
@cyyever cyyever requested review from AlekseiNikiforovIBM, jwfromm and malfet and removed request for malfet October 8, 2025 08:04
@AlekseiNikiforovIBM
Copy link
Collaborator

Was it fixed recently? Or why is it considered oudated? It still fails for me locally on s390x. I didn't look at ppc64le changes. ciflow/s390 label could be added to verify it on s390x CI.

test_tensor_creation_ops.py::TestTensorCreationCPU::test_float_to_int_conversion_nonfinite_cpu_bool PASSED [0.0028s]                                                                                  [ 16%] 
test_tensor_creation_ops.py::TestTensorCreationCPU::test_float_to_int_conversion_nonfinite_cpu_int16 FAILED [0.0023s]                                                                                 [ 33%] 
test_tensor_creation_ops.py::TestTensorCreationCPU::test_float_to_int_conversion_nonfinite_cpu_int32 FAILED [0.0014s]                                                                                 [ 50%] 
test_tensor_creation_ops.py::TestTensorCreationCPU::test_float_to_int_conversion_nonfinite_cpu_int64 FAILED [0.0013s]                                                                                 [ 66%] 
test_tensor_creation_ops.py::TestTensorCreationCPU::test_float_to_int_conversion_nonfinite_cpu_int8 FAILED [0.0020s]                                                                                  [ 83%] 
test_tensor_creation_ops.py::TestTensorCreationCPU::test_float_to_int_conversion_nonfinite_cpu_uint8 FAILED [0.0014s]                                                                                 [100%]

@cyyever cyyever marked this pull request as draft October 8, 2025 11:15
@cyyever cyyever added the ciflow/s390 s390x-related CI jobs label Oct 8, 2025
@AlekseiNikiforovIBM
Copy link
Collaborator

ppc part looks good to me, but maybe @sandeepgupta12 can provide more input on that part.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlekseiNikiforovIBM AlekseiNikiforovIBM Awaiting requested review from AlekseiNikiforovIBM

@malfet malfet Awaiting requested review from malfet

@jwfromm jwfromm Awaiting requested review from jwfromm

Assignees

No one assigned

Labels

ciflow/s390 s390x-related CI jobs open source topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cyyever @AlekseiNikiforovIBM @pytorchbot