Skip to content

Remove deprecated torch.nn.qat #164114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Remove deprecated torch.nn.qat #164114

wants to merge 2 commits into from

Conversation

cyyever
Copy link
Collaborator

@cyyever cyyever commented Sep 29, 2025 •
edited
Loading

This PR removes the deprecated torch/nn/qat folder.

@cyyever
Remove deprecated torch.nn.qat
6a71de8 
Signed-off-by: Yuanyuan Chen <[email protected]>
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Sep 29, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/164114

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 508ad2f with merge base 90512fa (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@cyyever cyyever requested review from sladyn98 and zou3519 and removed request for albanD, jbschlosser and mikaylagawarecki September 29, 2025 06:21
@cyyever cyyever added topic: deprecation topic category release notes: quantization release notes category labels Sep 29, 2025
@pytorch pytorch deleted a comment from github-actions bot Sep 29, 2025
@cyyever
Fix docs
508ad2f 
Signed-off-by: Yuanyuan Chen <[email protected]>
@soulitzer soulitzer added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Sep 29, 2025
@albanD albanD requested a review from jerryzh168 September 29, 2025 15:09
@jerryzh168
Copy link
Contributor

hmmm, we can't start deprecating these before we confirmed that it's safe I think, we still have internal users right now using all these things

jerryzh168
jerryzh168 requested changes Sep 29, 2025
View reviewed changes
Copy link
Contributor

@jerryzh168 jerryzh168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not ready to deprecate yet, can do this until we have sufficient understanding of internal usage and confirm it's safe to remove

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jerryzh168 jerryzh168 jerryzh168 requested changes

@zou3519 zou3519 Awaiting requested review from zou3519

@sladyn98 sladyn98 Awaiting requested review from sladyn98

Assignees

No one assigned

Labels

open source release notes: quantization release notes category topic: deprecation topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cyyever @jerryzh168 @soulitzer @pytorchbot