Skip to content

Conversation

eqy
Copy link
Collaborator

@eqy eqy commented Sep 16, 2025

Basically this test appears to fail when run with other tests that manipulate pinned memory, even with the @serialTest decorator

An ugly workaround here is to ensure it runs first due to alphabetical ordering...

cc @ptrblck @msaroufim @jerryzh168

@eqy eqy added module: cuda Related to torch.cuda, and CUDA support in general open source topic: not user facing topic category labels Sep 16, 2025
Copy link

pytorch-bot bot commented Sep 16, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/163119

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 67564ab with merge base d4554bc (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@zou3519 zou3519 requested review from ngimel and ptrblck September 18, 2025 14:16
@zou3519 zou3519 added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Sep 18, 2025
@ngimel
Copy link
Collaborator

ngimel commented Sep 18, 2025

which of the stats is failing? It's doing empty_cache so most should be fine, and we can relax checks on those that are failing rather than resort to ugly workarounds

@eqy
Copy link
Collaborator Author

eqy commented Sep 19, 2025

The failure signature I'm seeing most often is expecting 0 bytes host (pinned memory) and seeing 76 bytes allocated

@ngimel
Copy link
Collaborator

ngimel commented Sep 19, 2025

Fine, that means some other tests allocate and hold on to some memory, we can rewrite this test to be more robust to initial allocated memory (check that e.g. allocation is small in the beginning, and that it returns to this value in the end)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: cuda Related to torch.cuda, and CUDA support in general open source topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants