Skip to content

Put torchao (0.13.0) back to benchmark workflow #162227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Put torchao (0.13.0) back to benchmark workflow #162227

wants to merge 12 commits into from

Conversation

huydhn
Copy link
Contributor

@huydhn huydhn commented Sep 5, 2025

0.13.0 was released on Sep 3rd https://pypi.org/project/torchao/#history, which should have fixed the crashing issue on transformers now

@huydhn huydhn requested a review from jainapurva September 5, 2025 00:27
@huydhn huydhn requested review from jeffdaily and a team as code owners September 5, 2025 00:27
@pytorch-bot pytorch-bot bot added the release notes: releng release notes category label Sep 5, 2025
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Sep 5, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/162227

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 3b9b406 with merge base 23170df (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@huydhn huydhn added ciflow/inductor ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR labels Sep 5, 2025
@huydhn
Copy link
Contributor Author

huydhn commented Sep 7, 2025

@pytorchbot drci

@huydhn huydhn added ciflow/inductor-periodic and removed ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR labels Sep 7, 2025
@huydhn
Tiny comment update
636d3aa 
Signed-off-by: Huy Do <[email protected]>
huydhn
huydhn commented Sep 7, 2025
View reviewed changes
@huydhn
Copy link
Contributor Author

huydhn commented Sep 9, 2025

Nightly benchmark results looks good https://hud.pytorch.org/benchmark/compilers?dashboard=torchinductor&startTime=Tue%2C%2002%20Sep%202025%2002%3A39%3A44%20GMT&stopTime=Tue%2C%2009%20Sep%202025%2002%3A39%3A44%20GMT&granularity=hour&mode=inference&dtype=bfloat16&deviceName=cuda%20(h100)&lBranch=install-torchao-0.13.0&lCommit=8139b6b1b186b0fcc0e93a42f4d44e6dfd83bdc7&rBranch=main&rCommit=2a5c0785e2f975697fd7bdf1411de6e03dcaa1ef

@huydhn
Ready to land
78b4d25 
Signed-off-by: Huy Do <[email protected]>
@huydhn
Copy link
Contributor Author

huydhn commented Sep 9, 2025

@pytorchbot drci

1 similar comment
@huydhn
Copy link
Contributor Author

huydhn commented Sep 10, 2025

@pytorchbot drci

@huydhn
Copy link
Contributor Author

huydhn commented Sep 10, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 10, 2025
@huydhn huydhn added test-config/default and removed ciflow/trunk Trigger trunk jobs on your pull request labels Sep 10, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

@huydhn your PR has been successfully reverted.

pytorchmergebot added a commit that referenced this pull request Sep 10, 2025
@pytorchmergebot
Revert "Put torchao (0.13.0) back to benchmark workflow (#162227)"
80d4da8 
This reverts commit 0098597.

Reverted #162227 on behalf of https://github.com/huydhn due to Crashing some inductor jobs in trunk ([comment](#162227 (comment)))
@pytorchmergebot pytorchmergebot added Reverted ci-no-td Do not run TD on this PR labels Sep 10, 2025
@huydhn
Copy link
Contributor Author

huydhn commented Sep 10, 2025

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Rebase failed due to Command git -C /home/runner/work/pytorch/pytorch rebase refs/remotes/origin/viable/strict pull/162227/head returned non-zero exit code 1

Rebasing (1/7)
dropping 174f2faa8c57cd2908a2a42f6901833b5a1dcb79 Put torchao (0.13.0) back to benchmark workflow -- patch contents already upstream
Rebasing (2/7)
dropping 636d3aa00f2acf7c406f81bb654a340e0304cae7 Tiny comment update -- patch contents already upstream
Rebasing (3/7)
Auto-merging .github/ci_commit_pins/torchao.txt
CONFLICT (content): Merge conflict in .github/ci_commit_pins/torchao.txt
error: could not apply 24c95d83e6b... Bump torchao pinned commit
hint: Resolve all conflicts manually, mark them as resolved with
hint: "git add/rm <conflicted_files>", then run "git rebase --continue".
hint: You can instead skip this commit: run "git rebase --skip".
hint: To abort and get back to the state before "git rebase", run "git rebase --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Could not apply 24c95d83e6b... # Bump torchao pinned commit

Raised by https://github.com/pytorch/pytorch/actions/runs/17625855109

@jainapurva
Copy link
Contributor

@huydhn There's a similar issue being tracked in torchao pytorch/ao#2919

@huydhn
Copy link
Contributor Author

huydhn commented Sep 12, 2025

@huydhn There's a similar issue being tracked in torchao pytorch/ao#2919

Also, I think this doesn't work on ROCm, i.e. https://github.com/pytorch/pytorch/actions/runs/17662989900/job/50201696253 (correctly me if I'm wrong). So, I think I will avoid adding torchao to ROCm inductor jobs, and save it for later

@huydhn
Copy link
Contributor Author

huydhn commented Sep 12, 2025

@pytorchbot drci

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 12, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 1 checks: inductor-periodic / inductor-smoke-test / test (inductor_torchbench_smoketest_perf, 1, 1, linux.aws.a100)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: Comment with id 3286357684 not found

Details for Dev Infra team Raised by workflow job

markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
@huydhn @markc-614
Put torchao (0.13.0) back to benchmark workflow (pytorch#162227)
f8656da 
0.13.0 was released on Sep 3rd https://pypi.org/project/torchao/#history, which should have fixed the crashing issue on transformers now
Pull Request resolved: pytorch#162227
Approved by: https://github.com/malfet
markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
@pytorchmergebot @markc-614
Revert "Put torchao (0.13.0) back to benchmark workflow (pytorch#162227…
15e7523 
…)"

This reverts commit 0098597.

Reverted pytorch#162227 on behalf of https://github.com/huydhn due to Crashing some inductor jobs in trunk ([comment](pytorch#162227 (comment)))
mansiag05 pushed a commit to mansiag05/pytorch that referenced this pull request Sep 22, 2025
@huydhn @mansiag05
Put torchao (0.13.0) back to benchmark workflow (pytorch#162227)
f9f777b 
0.13.0 was released on Sep 3rd https://pypi.org/project/torchao/#history, which should have fixed the crashing issue on transformers now
Pull Request resolved: pytorch#162227
Approved by: https://github.com/malfet
mansiag05 pushed a commit to mansiag05/pytorch that referenced this pull request Sep 22, 2025
@pytorchmergebot @mansiag05
Revert "Put torchao (0.13.0) back to benchmark workflow (pytorch#162227…
c935b14 
…)"

This reverts commit 0098597.

Reverted pytorch#162227 on behalf of https://github.com/huydhn due to Crashing some inductor jobs in trunk ([comment](pytorch#162227 (comment)))
cleonard530 pushed a commit to cleonard530/pytorch that referenced this pull request Sep 22, 2025
@huydhn @cleonard530
Put torchao (0.13.0) back to benchmark workflow (pytorch#162227)
e797b7d 
0.13.0 was released on Sep 3rd https://pypi.org/project/torchao/#history, which should have fixed the crashing issue on transformers now
Pull Request resolved: pytorch#162227
Approved by: https://github.com/malfet
cleonard530 pushed a commit to cleonard530/pytorch that referenced this pull request Sep 22, 2025
@pytorchmergebot @cleonard530
Revert "Put torchao (0.13.0) back to benchmark workflow (pytorch#162227…
d26f3cc 
…)"

This reverts commit 0098597.

Reverted pytorch#162227 on behalf of https://github.com/huydhn due to Crashing some inductor jobs in trunk ([comment](pytorch#162227 (comment)))
dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
@huydhn @dsashidh
Put torchao (0.13.0) back to benchmark workflow (pytorch#162227)
68a8ddf 
0.13.0 was released on Sep 3rd https://pypi.org/project/torchao/#history, which should have fixed the crashing issue on transformers now
Pull Request resolved: pytorch#162227
Approved by: https://github.com/malfet
dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
@pytorchmergebot @dsashidh
Revert "Put torchao (0.13.0) back to benchmark workflow (pytorch#162227…
ef29298 
…)"

This reverts commit 0098597.

Reverted pytorch#162227 on behalf of https://github.com/huydhn due to Crashing some inductor jobs in trunk ([comment](pytorch#162227 (comment)))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malfet malfet malfet approved these changes

@jainapurva jainapurva Awaiting requested review from jainapurva

@jeffdaily jeffdaily Awaiting requested review from jeffdaily

Assignees
No one assigned
Labels
ci-no-td Do not run TD on this PR ciflow/inductor ciflow/inductor-micro-benchmark ciflow/inductor-periodic ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: releng release notes category Reverted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@huydhn @pytorchmergebot @anijain2305 @jainapurva @malfet