Skip to content

Call checkLong in is_int_or_symint, completing TODO #161692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

Call checkLong in is_int_or_symint, completing TODO #161692

wants to merge 6 commits into from

Conversation

swolchok
Copy link
Contributor

@swolchok swolchok commented Aug 28, 2025 •
edited
Loading

@swolchok
Call checkLong in is_int_or_symint, completing TODO
8fd9a26 
Calling this first minimizes overhead for plain old ints, making cheap things cheap.

[ghstack-poisoned]
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Aug 28, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/161692

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 7968432 with merge base 2b8a839 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This was referenced Aug 28, 2025
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Open
Closed
Closed
Closed
@swolchok
rebase on "Call checkLong in is_int_or_symint, completing TODO"
c940e62 
Calling this first minimizes overhead for plain old ints, making cheap things cheap.

[ghstack-poisoned]
@swolchok swolchok added the topic: not user facing topic category label Sep 2, 2025
@swolchok swolchok requested a review from albanD September 2, 2025 19:56
pytorchmergebot pushed a commit that referenced this pull request Sep 9, 2025
@swolchok @pytorchmergebot
Dynamo: set_eval_frame microoptimization (#162220)
e025c0f 
Optimize for common case and remove a pair of refcount operations (see new comments.)

Pull Request resolved: #162220
Approved by: https://github.com/jansel, https://github.com/williamwen42
ghstack dependencies: #161591, #161595, #161633, #161634, #161692, #162219
@swolchok swolchok mentioned this pull request Sep 9, 2025
Closed
pytorchmergebot pushed a commit that referenced this pull request Sep 10, 2025
@swolchok @pytorchmergebot
[easy] Don't force copy result of getAllOperatorsFor in init.cpp (#16…
0e7ccc0 
…2218)

It returns a const reference to a vector.

Pull Request resolved: #162218
Approved by: https://github.com/Skylion007
ghstack dependencies: #161591, #161595, #161633, #161634, #161692, #162219, #162220
pytorchmergebot pushed a commit that referenced this pull request Sep 11, 2025
@swolchok @pytorchmergebot
Remove logger.debug statements in DTensor dispatch (#161596)
f68f76d 
These seem to have been costing us 5-10 usec per detach (out of ~~95 usec total).  If they need to ship let's talk about requirements and how we can make this more efficient given that we would prefer if an entire DTensor op could finish in 10 usec.

Differential Revision: [D81530106](https://our.internmc.facebook.com/intern/diff/D81530106)
Pull Request resolved: #161596
Approved by: https://github.com/ezyang, https://github.com/Skylion007
ghstack dependencies: #161591, #161595, #161633, #161634, #161692, #162219, #162220, #162218
pytorchmergebot pushed a commit that referenced this pull request Sep 11, 2025
@swolchok @pytorchmergebot
Remove __torch_dispatch__ check in THPVariable_make_dtensor (#162337)
1274297 
We control DTensor, so we can just guarantee there isn't a programming error with __torch_dispatch__. (The guard is already less-than-perfect; see the note that the deleted comment refers to.)
Pull Request resolved: #162337
Approved by: https://github.com/Skylion007
ghstack dependencies: #161591, #161595, #161633, #161634, #161692, #162219, #162220, #162218, #161596
markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
@swolchok @markc-614
Call checkLong in is_int_or_symint, completing TODO (pytorch#161692)
4aca2d6 
Calling this first minimizes overhead for plain old ints, making cheap things cheap.

Differential Revision: [D81530098](https://our.internmc.facebook.com/intern/diff/D81530098)
Pull Request resolved: pytorch#161692
Approved by: https://github.com/ezyang, https://github.com/Skylion007
ghstack dependencies: pytorch#161591, pytorch#161595, pytorch#161633, pytorch#161634
markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
@swolchok @markc-614
Overload _get_operation_for_overload_or_packet & friends to accept Ar…
599c325 
…rayRef (pytorch#162219)

Avoids requiring vector allocation to call this.

Pull Request resolved: pytorch#162219
Approved by: https://github.com/Skylion007
ghstack dependencies: pytorch#161591, pytorch#161595, pytorch#161633, pytorch#161634, pytorch#161692
markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
@swolchok @markc-614
Dynamo: set_eval_frame microoptimization (pytorch#162220)
cd39fd5 
Optimize for common case and remove a pair of refcount operations (see new comments.)

Pull Request resolved: pytorch#162220
Approved by: https://github.com/jansel, https://github.com/williamwen42
ghstack dependencies: pytorch#161591, pytorch#161595, pytorch#161633, pytorch#161634, pytorch#161692, pytorch#162219
markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
@swolchok @markc-614
[easy] Don't force copy result of getAllOperatorsFor in init.cpp (pyt…
78360df 
…orch#162218)

It returns a const reference to a vector.

Pull Request resolved: pytorch#162218
Approved by: https://github.com/Skylion007
ghstack dependencies: pytorch#161591, pytorch#161595, pytorch#161633, pytorch#161634, pytorch#161692, pytorch#162219, pytorch#162220
markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
@swolchok @markc-614
Remove logger.debug statements in DTensor dispatch (pytorch#161596)
6b94f2e 
These seem to have been costing us 5-10 usec per detach (out of ~~95 usec total).  If they need to ship let's talk about requirements and how we can make this more efficient given that we would prefer if an entire DTensor op could finish in 10 usec.

Differential Revision: [D81530106](https://our.internmc.facebook.com/intern/diff/D81530106)
Pull Request resolved: pytorch#161596
Approved by: https://github.com/ezyang, https://github.com/Skylion007
ghstack dependencies: pytorch#161591, pytorch#161595, pytorch#161633, pytorch#161634, pytorch#161692, pytorch#162219, pytorch#162220, pytorch#162218
markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
@swolchok @markc-614
Remove __torch_dispatch__ check in THPVariable_make_dtensor (pytorch#…
552acc9 
…162337)

We control DTensor, so we can just guarantee there isn't a programming error with __torch_dispatch__. (The guard is already less-than-perfect; see the note that the deleted comment refers to.)
Pull Request resolved: pytorch#162337
Approved by: https://github.com/Skylion007
ghstack dependencies: pytorch#161591, pytorch#161595, pytorch#161633, pytorch#161634, pytorch#161692, pytorch#162219, pytorch#162220, pytorch#162218, pytorch#161596
mansiag05 pushed a commit to mansiag05/pytorch that referenced this pull request Sep 22, 2025
@swolchok @mansiag05
Call checkLong in is_int_or_symint, completing TODO (pytorch#161692)
b178f13 
Calling this first minimizes overhead for plain old ints, making cheap things cheap.

Differential Revision: [D81530098](https://our.internmc.facebook.com/intern/diff/D81530098)
Pull Request resolved: pytorch#161692
Approved by: https://github.com/ezyang, https://github.com/Skylion007
ghstack dependencies: pytorch#161591, pytorch#161595, pytorch#161633, pytorch#161634
mansiag05 pushed a commit to mansiag05/pytorch that referenced this pull request Sep 22, 2025
@swolchok @mansiag05
Overload _get_operation_for_overload_or_packet & friends to accept Ar…
155611d 
…rayRef (pytorch#162219)

Avoids requiring vector allocation to call this.

Pull Request resolved: pytorch#162219
Approved by: https://github.com/Skylion007
ghstack dependencies: pytorch#161591, pytorch#161595, pytorch#161633, pytorch#161634, pytorch#161692
mansiag05 pushed a commit to mansiag05/pytorch that referenced this pull request Sep 22, 2025
@swolchok @mansiag05
Dynamo: set_eval_frame microoptimization (pytorch#162220)
d2b451a 
Optimize for common case and remove a pair of refcount operations (see new comments.)

Pull Request resolved: pytorch#162220
Approved by: https://github.com/jansel, https://github.com/williamwen42
ghstack dependencies: pytorch#161591, pytorch#161595, pytorch#161633, pytorch#161634, pytorch#161692, pytorch#162219
mansiag05 pushed a commit to mansiag05/pytorch that referenced this pull request Sep 22, 2025
@swolchok @mansiag05
[easy] Don't force copy result of getAllOperatorsFor in init.cpp (pyt…
8d8e4dd 
…orch#162218)

It returns a const reference to a vector.

Pull Request resolved: pytorch#162218
Approved by: https://github.com/Skylion007
ghstack dependencies: pytorch#161591, pytorch#161595, pytorch#161633, pytorch#161634, pytorch#161692, pytorch#162219, pytorch#162220
mansiag05 pushed a commit to mansiag05/pytorch that referenced this pull request Sep 22, 2025
@swolchok @mansiag05
Remove logger.debug statements in DTensor dispatch (pytorch#161596)
36bcf56 
These seem to have been costing us 5-10 usec per detach (out of ~~95 usec total).  If they need to ship let's talk about requirements and how we can make this more efficient given that we would prefer if an entire DTensor op could finish in 10 usec.

Differential Revision: [D81530106](https://our.internmc.facebook.com/intern/diff/D81530106)
Pull Request resolved: pytorch#161596
Approved by: https://github.com/ezyang, https://github.com/Skylion007
ghstack dependencies: pytorch#161591, pytorch#161595, pytorch#161633, pytorch#161634, pytorch#161692, pytorch#162219, pytorch#162220, pytorch#162218
mansiag05 pushed a commit to mansiag05/pytorch that referenced this pull request Sep 22, 2025
@swolchok @mansiag05
Remove __torch_dispatch__ check in THPVariable_make_dtensor (pytorch#…
29ae870 
…162337)

We control DTensor, so we can just guarantee there isn't a programming error with __torch_dispatch__. (The guard is already less-than-perfect; see the note that the deleted comment refers to.)
Pull Request resolved: pytorch#162337
Approved by: https://github.com/Skylion007
ghstack dependencies: pytorch#161591, pytorch#161595, pytorch#161633, pytorch#161634, pytorch#161692, pytorch#162219, pytorch#162220, pytorch#162218, pytorch#161596
cleonard530 pushed a commit to cleonard530/pytorch that referenced this pull request Sep 22, 2025
@swolchok @cleonard530
Call checkLong in is_int_or_symint, completing TODO (pytorch#161692)
3b70941 
Calling this first minimizes overhead for plain old ints, making cheap things cheap.

Differential Revision: [D81530098](https://our.internmc.facebook.com/intern/diff/D81530098)
Pull Request resolved: pytorch#161692
Approved by: https://github.com/ezyang, https://github.com/Skylion007
ghstack dependencies: pytorch#161591, pytorch#161595, pytorch#161633, pytorch#161634
cleonard530 pushed a commit to cleonard530/pytorch that referenced this pull request Sep 22, 2025
@swolchok @cleonard530
Overload _get_operation_for_overload_or_packet & friends to accept Ar…
7949488 
…rayRef (pytorch#162219)

Avoids requiring vector allocation to call this.

Pull Request resolved: pytorch#162219
Approved by: https://github.com/Skylion007
ghstack dependencies: pytorch#161591, pytorch#161595, pytorch#161633, pytorch#161634, pytorch#161692
cleonard530 pushed a commit to cleonard530/pytorch that referenced this pull request Sep 22, 2025
@swolchok @cleonard530
Dynamo: set_eval_frame microoptimization (pytorch#162220)
1e2f8af 
Optimize for common case and remove a pair of refcount operations (see new comments.)

Pull Request resolved: pytorch#162220
Approved by: https://github.com/jansel, https://github.com/williamwen42
ghstack dependencies: pytorch#161591, pytorch#161595, pytorch#161633, pytorch#161634, pytorch#161692, pytorch#162219
cleonard530 pushed a commit to cleonard530/pytorch that referenced this pull request Sep 22, 2025
@swolchok @cleonard530
[easy] Don't force copy result of getAllOperatorsFor in init.cpp (pyt…
ac0682e 
…orch#162218)

It returns a const reference to a vector.

Pull Request resolved: pytorch#162218
Approved by: https://github.com/Skylion007
ghstack dependencies: pytorch#161591, pytorch#161595, pytorch#161633, pytorch#161634, pytorch#161692, pytorch#162219, pytorch#162220
cleonard530 pushed a commit to cleonard530/pytorch that referenced this pull request Sep 22, 2025
@swolchok @cleonard530
Remove logger.debug statements in DTensor dispatch (pytorch#161596)
9797862 
These seem to have been costing us 5-10 usec per detach (out of ~~95 usec total).  If they need to ship let's talk about requirements and how we can make this more efficient given that we would prefer if an entire DTensor op could finish in 10 usec.

Differential Revision: [D81530106](https://our.internmc.facebook.com/intern/diff/D81530106)
Pull Request resolved: pytorch#161596
Approved by: https://github.com/ezyang, https://github.com/Skylion007
ghstack dependencies: pytorch#161591, pytorch#161595, pytorch#161633, pytorch#161634, pytorch#161692, pytorch#162219, pytorch#162220, pytorch#162218
cleonard530 pushed a commit to cleonard530/pytorch that referenced this pull request Sep 22, 2025
@swolchok @cleonard530
Remove __torch_dispatch__ check in THPVariable_make_dtensor (pytorch#…
c6719fe 
…162337)

We control DTensor, so we can just guarantee there isn't a programming error with __torch_dispatch__. (The guard is already less-than-perfect; see the note that the deleted comment refers to.)
Pull Request resolved: pytorch#162337
Approved by: https://github.com/Skylion007
ghstack dependencies: pytorch#161591, pytorch#161595, pytorch#161633, pytorch#161634, pytorch#161692, pytorch#162219, pytorch#162220, pytorch#162218, pytorch#161596
dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
@swolchok @dsashidh
Call checkLong in is_int_or_symint, completing TODO (pytorch#161692)
d39e6fe 
Calling this first minimizes overhead for plain old ints, making cheap things cheap.

Differential Revision: [D81530098](https://our.internmc.facebook.com/intern/diff/D81530098)
Pull Request resolved: pytorch#161692
Approved by: https://github.com/ezyang, https://github.com/Skylion007
ghstack dependencies: pytorch#161591, pytorch#161595, pytorch#161633, pytorch#161634
dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
@swolchok @dsashidh
Overload _get_operation_for_overload_or_packet & friends to accept Ar…
8a1910d 
…rayRef (pytorch#162219)

Avoids requiring vector allocation to call this.

Pull Request resolved: pytorch#162219
Approved by: https://github.com/Skylion007
ghstack dependencies: pytorch#161591, pytorch#161595, pytorch#161633, pytorch#161634, pytorch#161692
dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
@swolchok @dsashidh
Dynamo: set_eval_frame microoptimization (pytorch#162220)
ca1c240 
Optimize for common case and remove a pair of refcount operations (see new comments.)

Pull Request resolved: pytorch#162220
Approved by: https://github.com/jansel, https://github.com/williamwen42
ghstack dependencies: pytorch#161591, pytorch#161595, pytorch#161633, pytorch#161634, pytorch#161692, pytorch#162219
dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
@swolchok @dsashidh
[easy] Don't force copy result of getAllOperatorsFor in init.cpp (pyt…
127667e 
…orch#162218)

It returns a const reference to a vector.

Pull Request resolved: pytorch#162218
Approved by: https://github.com/Skylion007
ghstack dependencies: pytorch#161591, pytorch#161595, pytorch#161633, pytorch#161634, pytorch#161692, pytorch#162219, pytorch#162220
dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
@swolchok @dsashidh
Remove logger.debug statements in DTensor dispatch (pytorch#161596)
48e1283 
These seem to have been costing us 5-10 usec per detach (out of ~~95 usec total).  If they need to ship let's talk about requirements and how we can make this more efficient given that we would prefer if an entire DTensor op could finish in 10 usec.

Differential Revision: [D81530106](https://our.internmc.facebook.com/intern/diff/D81530106)
Pull Request resolved: pytorch#161596
Approved by: https://github.com/ezyang, https://github.com/Skylion007
ghstack dependencies: pytorch#161591, pytorch#161595, pytorch#161633, pytorch#161634, pytorch#161692, pytorch#162219, pytorch#162220, pytorch#162218
dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
@swolchok @dsashidh
Remove __torch_dispatch__ check in THPVariable_make_dtensor (pytorch#…
e5e1f10 
…162337)

We control DTensor, so we can just guarantee there isn't a programming error with __torch_dispatch__. (The guard is already less-than-perfect; see the note that the deleted comment refers to.)
Pull Request resolved: pytorch#162337
Approved by: https://github.com/Skylion007
ghstack dependencies: pytorch#161591, pytorch#161595, pytorch#161633, pytorch#161634, pytorch#161692, pytorch#162219, pytorch#162220, pytorch#162218, pytorch#161596
@github-actions github-actions bot deleted the gh/swolchok/820/head branch October 9, 2025 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezyang ezyang ezyang approved these changes

@Skylion007 Skylion007 Skylion007 approved these changes

@albanD albanD Awaiting requested review from albanD

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@swolchok @ezyang @pytorchmergebot @Skylion007