Skip to content

[Submodule] Bump kineto to latest #161370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Submodule] Bump kineto to latest #161370

wants to merge 1 commit into from

Conversation

cyyever
Copy link
Collaborator

@cyyever cyyever commented Aug 24, 2025 •
edited
Loading

Simplify the CUPTI check because kineto has used CUDA::cupti.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Aug 24, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/161370

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 161d268 with merge base 5f25dbe (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@cyyever cyyever added release notes: profiler release notes category topic: not user facing topic category and removed release notes: profiler release notes category labels Aug 24, 2025
@cyyever
Copy link
Collaborator Author

cyyever commented Aug 25, 2025

@pytorchmergebot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 25, 2025
@cyyever
Copy link
Collaborator Author

cyyever commented Aug 25, 2025

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Tried to rebase and push PR #161370, but it was already up to date. Try rebasing against main by issuing:
@pytorchbot rebase -b main

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / win-vs2022-cuda12.6-py3 / build

Details for Dev Infra team Raised by workflow job

@sraikund16
Copy link
Contributor

@cyyever is https://github.com/pytorch/kineto/pull/1127/files supposed to fix the windows build issue here?

@cyyever
Copy link
Collaborator Author

cyyever commented Aug 25, 2025

@sraikund16 No, I haven't checked the Windows issue.

@cyyever cyyever mentioned this pull request Aug 25, 2025
Closed
facebook-github-bot pushed a commit to pytorch/kineto that referenced this pull request Aug 26, 2025
@cyyever @facebook-github-bot
Link to CUDA::nvperf_host publicly (#1129)
87eb133 
Summary:
An attempt to fix the Windows build failure in pytorch/pytorch#161370 (comment)

Pull Request resolved: #1129

Reviewed By: anubhavchaturvedi, hsgadre

Differential Revision: D80967726

Pulled By: sraikund16

fbshipit-source-id: fe86c9b4bd17cb08a918d223a9605eb36b5bad57
@cyyever cyyever force-pushed the libkineto branch 2 times, most recently from b07484d to 651233c Compare August 26, 2025 01:28
@sraikund16
Copy link
Contributor

@cyyever it looks like it is still failing with the same signature :(

@sraikund16
Copy link
Contributor

@cyyever I did notice the note in this PR pytorch/kineto#1109:

Note: Windows shared builds don't work because no C++ symbol exported, this failure doesn't affect PyTorch builds because it always uses static builds.. This serious failure should be fixed in a later PR.

Did you plan on fixing it before bumping the version?

@cyyever
Copy link
Collaborator Author

cyyever commented Aug 26, 2025 •
edited
Loading

@sraikund16 Any idea about what symbols to export? Or simply export all symbols?

@sraikund16
Copy link
Contributor

@sraikund16 Any idea about what symbols to export? Or simply export all symbols?

added note in pytorch/kineto#1130

@sraikund16
Copy link
Contributor

Looks like it is breaking for another reason now, so the cmakefile fix worked. Going to fix the lambda that is causing issues

@cyyever cyyever force-pushed the libkineto branch 2 times, most recently from a6427b3 to f06e4a7 Compare August 30, 2025 00:34
@cyyever
Bump kineto to latest
161d268 
Signed-off-by: cyy <[email protected]>
Signed-off-by: Yuanyuan Chen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

@sraikund16 sraikund16 Awaiting requested review from sraikund16

@malfet malfet Awaiting requested review from malfet

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request open source topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cyyever @pytorchmergebot @sraikund16 @Skylion007 @pytorchbot