Skip to content

Conversation

naromero77amd
Copy link
Collaborator

@naromero77amd naromero77amd commented Aug 22, 2025

Copy link

pytorch-bot bot commented Aug 22, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/161280

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 291ee06 with merge base 81dbeb0 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added module: inductor module: rocm AMD GPU support for Pytorch labels Aug 22, 2025
@naromero77amd naromero77amd marked this pull request as draft August 22, 2025 16:59
@pytorch-bot pytorch-bot bot added ciflow/inductor ciflow/rocm Trigger "default" config CI on ROCm labels Aug 22, 2025
Copy link

pytorch-bot bot commented Aug 22, 2025

To add the ciflow label ciflow/inductor please first approve the workflows that are awaiting approval (scroll to the bottom of this page).

This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows.

Copy link

pytorch-bot bot commented Aug 22, 2025

To add the ciflow label ciflow/rocm please first approve the workflows that are awaiting approval (scroll to the bottom of this page).

This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows.

@pytorch-bot pytorch-bot bot removed ciflow/inductor ciflow/rocm Trigger "default" config CI on ROCm labels Aug 22, 2025
@naromero77amd naromero77amd added the release notes: rocm mandatorylabel label Aug 22, 2025
@facebook-github-bot
Copy link
Contributor

@haoyuz has imported this pull request. If you are a Meta employee, you can view this in D80836468.

@facebook-github-bot
Copy link
Contributor

@haoyuz has imported this pull request. If you are a Meta employee, you can view this in D80836468.

@naromero77amd naromero77amd changed the title [WIP][inductor][ROCm] MI350 perf tuning [WIP][inductor][ROCm] MI350 reduction heuristics improvements Sep 11, 2025
@naromero77amd naromero77amd marked this pull request as ready for review September 11, 2025 22:24
@naromero77amd naromero77amd marked this pull request as draft September 11, 2025 22:24
@facebook-github-bot
Copy link
Contributor

@haoyuz has imported this pull request. If you are a Meta employee, you can view this in D80836468.

@jataylo
Copy link
Collaborator

jataylo commented Sep 23, 2025

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Rebase failed due to Command git -C /home/runner/work/pytorch/pytorch rebase refs/remotes/origin/viable/strict pull/161280/head returned non-zero exit code 1

Rebasing (1/18)
Auto-merging torch/_inductor/codegen/triton.py
Auto-merging torch/_inductor/runtime/triton_heuristics.py
CONFLICT (content): Merge conflict in torch/_inductor/runtime/triton_heuristics.py
error: could not apply d1e5254957a... Added triton perf improvement changes
hint: Resolve all conflicts manually, mark them as resolved with
hint: "git add/rm <conflicted_files>", then run "git rebase --continue".
hint: You can instead skip this commit: run "git rebase --skip".
hint: To abort and get back to the state before "git rebase", run "git rebase --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Could not apply d1e5254957a... # Added triton perf improvement changes

Raised by https://github.com/pytorch/pytorch/actions/runs/17948121352

@naromero77amd naromero77amd changed the title [WIP][inductor][ROCm] MI350 reduction heuristics improvements [inductor][ROCm] MI350 reduction heuristics improvements Sep 26, 2025
@pytorch-bot pytorch-bot bot added ciflow/inductor ciflow/rocm Trigger "default" config CI on ROCm labels Sep 26, 2025
@naromero77amd naromero77amd changed the title [inductor][ROCm] MI350 reduction heuristics improvements [ROCm][inductor] MI350 reduction heuristics improvements Sep 26, 2025
@pytorch-bot pytorch-bot bot removed ciflow/inductor ciflow/rocm Trigger "default" config CI on ROCm labels Sep 27, 2025
@jeffdaily jeffdaily added the ciflow/inductor-rocm Trigger "inductor" config CI on ROCm label Oct 2, 2025
@naromero77amd naromero77amd changed the title [ROCm][inductor] MI350 reduction heuristics improvements [ROCm][inductor] heuristics improvements for reductions Oct 2, 2025
@pytorch-bot pytorch-bot bot added the ciflow/rocm Trigger "default" config CI on ROCm label Oct 2, 2025
@naromero77amd naromero77amd changed the title [ROCm][inductor] heuristics improvements for reductions [ROCm][inductor] heuristics improvement for reductions Oct 2, 2025
@naromero77amd naromero77amd changed the title [ROCm][inductor] heuristics improvement for reductions [ROCm][inductor] heuristic improvements for reductions Oct 2, 2025
@naromero77amd naromero77amd changed the title [ROCm][inductor] heuristic improvements for reductions [ROCm][inductor] heuristic improvements for reduction kernels Oct 2, 2025
@pytorch-bot pytorch-bot bot removed ciflow/inductor ciflow/rocm Trigger "default" config CI on ROCm ciflow/inductor-rocm Trigger "inductor" config CI on ROCm labels Oct 8, 2025
@jeffdaily jeffdaily added ciflow/inductor ciflow/rocm Trigger "default" config CI on ROCm ciflow/inductor-rocm Trigger "inductor" config CI on ROCm ciflow/rocm-mi300 Trigger "default" config CI on ROCm MI300 labels Oct 8, 2025
@jeffdaily
Copy link
Collaborator

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased mi350_perf_tuning onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout mi350_perf_tuning && git pull --rebase)

@pytorch-bot pytorch-bot bot removed ciflow/inductor ciflow/rocm Trigger "default" config CI on ROCm ciflow/inductor-rocm Trigger "inductor" config CI on ROCm ciflow/rocm-mi300 Trigger "default" config CI on ROCm MI300 labels Oct 9, 2025
@jeffdaily jeffdaily added ciflow/inductor ciflow/rocm Trigger "default" config CI on ROCm ciflow/inductor-rocm Trigger "inductor" config CI on ROCm ciflow/rocm-mi300 Trigger "default" config CI on ROCm MI300 labels Oct 9, 2025
@naromero77amd naromero77amd marked this pull request as ready for review October 10, 2025 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/inductor ciflow/inductor-rocm Trigger "inductor" config CI on ROCm ciflow/rocm Trigger "default" config CI on ROCm ciflow/rocm-mi300 Trigger "default" config CI on ROCm MI300 module: inductor module: rocm AMD GPU support for Pytorch open source release notes: rocm mandatorylabel

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants