Skip to content

[CUDA] Don't import hipify modules on CUDA #161107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[CUDA] Don't import hipify modules on CUDA #161107

wants to merge 2 commits into from

Conversation

eqy
Copy link
Collaborator

@eqy eqy commented Aug 20, 2025 •
edited by pytorch-bot bot
Loading

@eqy eqy requested review from ezyang, fmassa and malfet as code owners August 20, 2025 23:13
@eqy eqy added module: cuda Related to torch.cuda, and CUDA support in general open source topic: not user facing topic category labels Aug 20, 2025
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Aug 20, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/161107

Note: Links to docs will display an error until the docs builds have been completed.

❌ 30 New Failures, 2 Unrelated Failures

As of commit ca5745e with merge base 44549c7 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@soulitzer soulitzer added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Aug 26, 2025
ezyang
ezyang approved these changes Aug 31, 2025
View reviewed changes
Copy link
Contributor

@ezyang ezyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though, I would prefer it if it was imported at the use site instead. LLM should be able to refactor this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezyang ezyang ezyang approved these changes

@fmassa fmassa Awaiting requested review from fmassa fmassa is a code owner

@malfet malfet Awaiting requested review from malfet malfet is a code owner

Assignees

No one assigned

Labels

ciflow/inductor module: cuda Related to torch.cuda, and CUDA support in general module: inductor open source release notes: inductor (aoti) topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eqy @ezyang @soulitzer