Skip to content

Fix skipIfXpu and skipIfHpu and similar skip decorators #159862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix skipIfXpu and skipIfHpu and similar skip decorators #159862

wants to merge 2 commits into from

Conversation

Flamefire
Copy link
Collaborator

@Flamefire Flamefire commented Aug 5, 2025 •
edited
Loading

The decorators won't work when used on classes so use the unittest skip functions in their implementation.
In many cases those can be simple aliases.

Fixes #150779

@Flamefire Flamefire requested a review from a team as a code owner August 5, 2025 13:36
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Aug 5, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/159862

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit fa28ff2 with merge base 25c170b (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@Flamefire Flamefire force-pushed the skipxpuhpu-markers branch from cc7a1ec to 7984b83 Compare August 5, 2025 13:37
@Flamefire Flamefire mentioned this pull request Aug 5, 2025
Closed
@Flamefire
Copy link
Collaborator Author

@pytorchbot label "topic: not user facing"

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Aug 5, 2025
@Flamefire Flamefire force-pushed the skipxpuhpu-markers branch from 7984b83 to 6a8f9b9 Compare August 6, 2025 07:09
@Flamefire Flamefire changed the title Fix skipIfXpu and skipIfHp and similar skip decorators Fix skipIfXpu and skipIfHpu and similar skip decorators Aug 6, 2025
@Flamefire Flamefire force-pushed the skipxpuhpu-markers branch from 6a8f9b9 to 4876364 Compare August 6, 2025 07:38
@jerryzh168 jerryzh168 added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Aug 13, 2025
@Flamefire
Copy link
Collaborator Author

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@Flamefire @pytorchmergebot
Fix skipIfXpu and skipIfHpu and similar skip decorators
2dde45f 
The decorators won't work when used on classes so use the unittest skip
functions in their implementation.
In many cases those can be simple aliases.

Fixes pytorch#150779
@pytorchmergebot
Copy link
Collaborator

Successfully rebased skipxpuhpu-markers onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout skipxpuhpu-markers && git pull --rebase)

@Flamefire
Copy link
Collaborator Author

Failure seems to be unrelated. Please review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skylion007 Skylion007 Awaiting requested review from Skylion007

@malfet malfet Awaiting requested review from malfet

Assignees

No one assigned

Labels

open source topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Decorator skipIfXpu disables tests when used on class

4 participants

@Flamefire @pytorchmergebot @jerryzh168 @pytorchbot