Skip to content

Add binary size check to validate current limits for binaries released to pypi #159768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add binary size check to validate current limits for binaries released to pypi #159768

wants to merge 3 commits into from

Conversation

atalman
Copy link
Contributor

@atalman atalman commented Aug 4, 2025 •
edited
Loading

Adding check in linux binary validations, trying to mitigate binary size increase for binaries released to pypi:

Reference issues:
2.7.0: #150647
2.8.0: #159515

Trying to mitigate:
#159516

@atalman atalman requested a review from a team as a code owner August 4, 2025 15:25
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Aug 4, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/159768

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ You can merge normally! (1 Unrelated Failure)

As of commit a29e7df with merge base e5a81aa (image):

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

  • pull / linux-jammy-py3_9-clang9-xla / test (xla, 1, 1, linux.12xlarge, unstable) (gh) (#158876)
    /var/lib/jenkins/workspace/xla/torch_xla/csrc/runtime/BUILD:476:14: Compiling torch_xla/csrc/runtime/xla_util_test.cpp failed: (Exit 1): gcc failed: error executing CppCompile command (from target //torch_xla/csrc/runtime:xla_util_test) /usr/bin/gcc -U_FORTIFY_SOURCE -fstack-protector -Wall -Wunused-but-set-parameter -Wno-free-nonheap-object -fno-omit-frame-pointer -g0 -O2 '-D_FORTIFY_SOURCE=1' -DNDEBUG -ffunction-sections ... (remaining 229 arguments skipped)

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Aug 4, 2025
atalman
atalman commented Aug 4, 2025
View reviewed changes
.github/scripts/generate_binary_build_matrix.py

CUDA_AARCH64_ARCHES = ["12.9-aarch64"]

# current binary limits for each platform released to PyPI
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are both CU 12.8 and CU 12.9 are listed since we will probably promote Experimental CUDA 12.9 builds to pypi in future releases

@atalman atalman mentioned this pull request Aug 4, 2025
Open
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 4, 2025

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the Stale label Oct 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

Assignees

No one assigned

Labels

Stale topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@atalman @Skylion007