[BE] remove torch deploy - conditionals #158288

PaliC · 2025-07-14T22:20:38Z

Stack from ghstack (oldest at bottom):

This PR is part of the work to deprecate torch::deploy in OSS. Effectively it does 3 things to get started.

Remove test_deploy_interaction as we no longer need to worry about this
Remove all torch._running_with_deploy checks and use the False path always (surfaced 1)
Remove USE_DEPLOY and switch to the default path always

Note: MyPy does fail on a bunch of things here as a bunch of older files are touched. It may be better to fix these things on a separate PR

cc @H-Huang @awgu @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @pragupta @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben @Lucaskabela

[ghstack-poisoned]

pytorch-bot · 2025-07-14T22:20:42Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/158288

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit ae3d13e with merge base e067981 ():

FLAKY - The following job failed but was likely due to flakiness present on trunk:

trunk / linux-jammy-rocm-py3.10 / test (distributed, 1, 1, linux.rocm.gpu.4) (gh) (similar failure)
distributed/test_c10d_nccl.py::DistributedDataParallelTest::test_grad_layout_1devicemodule_1replicaperprocess

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

pull / linux-jammy-py3_9-clang9-xla / test (xla, 1, 1, linux.12xlarge, unstable) (gh) (#158876)
sccache: error: couldn't connect to server

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[ghstack-poisoned]

albanD

Very nice!

torch/csrc/utils/python_dispatch.cpp

albanD · 2025-07-15T15:02:32Z

torch/distributed/_functional_collectives.py

+try:
+    from torch.compiler import is_dynamo_compiling as is_torchdynamo_compiling
+except Exception:
+    warnings.warn(
+        "Unable to import torchdynamo util `is_torchdynamo_compiling`, so won't support torchdynamo correctly"
+    )


@jansel this looks pretty bad right?

Nothing for you to do in this PR Sahan, just flagging.

[ghstack-poisoned]

This PR is part of the work to deprecate torch::deploy in OSS. Effectively it does 3 things to get started. 1. Remove test_deploy_interaction as we no longer need to worry about this 2. Remove all torch._running_with_deploy checks and use the False path always (surfaced 1) 3. Remove `USE_DEPLOY` and switch to the default path always Note: MyPy does fail on a bunch of things here as a bunch of older files are touched. It may be better to fix these things on a separate PR cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov [ghstack-poisoned]

pytorchmergebot · 2025-07-15T21:51:31Z

Starting merge as part of PR stack under #158290

pytorchmergebot · 2025-07-15T21:51:52Z

Starting merge as part of PR stack under #158291

pytorchmergebot · 2025-07-16T02:57:26Z

Starting merge as part of PR stack under #158291

…se (#158407) This PR makes some less risky changes to PyObjectSlot as there is a lot of stuff we do not need since there is only one interpreter. Specifically `check_interpreter` and `has_pyobj_nonhermetic` are removed Pull Request resolved: #158407 Approved by: https://github.com/albanD ghstack dependencies: #158288, #158290, #158291

PaliC · 2025-07-25T07:01:59Z

@pytorchbot revert

pytorch-bot · 2025-07-25T07:02:02Z

❌ 🤖 pytorchbot command failed:

@pytorchbot revert: error: the following arguments are required: -m/--message, -c/--classification

usage: @pytorchbot revert -m MESSAGE -c
                          {nosignal,ignoredsignal,landrace,weird,ghfirst}

Try @pytorchbot --help for more info.

ZainRizvi · 2025-07-25T16:07:47Z

@pytorchbot revert -c ghfirst -m "Reverting as per offline discussion to fix internal breaks. @PaliC will reland this as a codev diff. Instructions here: https://fburl.com/fixing-ghfirst-reverts"

pytorchmergebot · 2025-07-25T16:09:20Z

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

@PaliC

… is in use (#158407)" This reverts commit 255c054. Reverted #158407 on behalf of https://github.com/ZainRizvi due to Reverting as per offline discussion to fix internal breaks. @PaliC will reland this as a codev diff. Instructions here: https://fburl.com/fixing-ghfirst-reverts ([comment](#158288 (comment)))

@PaliC

This reverts commit 9c68c4d. Reverted #158291 on behalf of https://github.com/ZainRizvi due to Reverting as per offline discussion to fix internal breaks. @PaliC will reland this as a codev diff. Instructions here: https://fburl.com/fixing-ghfirst-reverts ([comment](#158288 (comment)))

@PaliC

…#158290)" This reverts commit 6ed2cb6. Reverted #158290 on behalf of https://github.com/ZainRizvi due to Reverting as per offline discussion to fix internal breaks. @PaliC will reland this as a codev diff. Instructions here: https://fburl.com/fixing-ghfirst-reverts ([comment](#158288 (comment)))

@PaliC

This reverts commit ab26d4f. Reverted #158288 on behalf of https://github.com/ZainRizvi due to Reverting as per offline discussion to fix internal breaks. @PaliC will reland this as a codev diff. Instructions here: https://fburl.com/fixing-ghfirst-reverts ([comment](#158288 (comment)))

pytorchmergebot · 2025-07-25T16:09:53Z

@PaliC your PR has been successfully reverted.

This PR is part of the work to deprecate torch::deploy in OSS. Effectively it does 3 things to get started. 1. Remove test_deploy_interaction as we no longer need to worry about this 2. Remove all torch._running_with_deploy checks and use the False path always (surfaced 1) 3. Remove `USE_DEPLOY` and switch to the default path always Note: MyPy does fail on a bunch of things here as a bunch of older files are touched. It may be better to fix these things on a separate PR cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k pragupta voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov coconutruben Lucaskabela [ghstack-poisoned]

PaliC · 2025-07-28T23:15:30Z

@pytorchbot merge

PaliC · 2025-07-29T17:32:55Z

@pytorchbot merge -i

pytorchmergebot · 2025-07-29T17:34:58Z

Merge started

Your change will be merged while ignoring the following 2 checks: pull / linux-jammy-py3_9-clang9-xla / test (xla, 1, 1, linux.12xlarge, unstable), trunk / linux-jammy-rocm-py3.10 / test (distributed, 1, 1, linux.rocm.gpu.4)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

@PaliC

… is in use (#158407)" This reverts commit 255c054. Reverted #158407 on behalf of https://github.com/ZainRizvi due to Reverting as per offline discussion to fix internal breaks. @PaliC will reland this as a codev diff. Instructions here: https://fburl.com/fixing-ghfirst-reverts ([comment](#158288 (comment)))

@PaliC

This reverts commit 9c68c4d. Reverted #158291 on behalf of https://github.com/ZainRizvi due to Reverting as per offline discussion to fix internal breaks. @PaliC will reland this as a codev diff. Instructions here: https://fburl.com/fixing-ghfirst-reverts ([comment](#158288 (comment)))

@PaliC

…#158290)" This reverts commit 6ed2cb6. Reverted #158290 on behalf of https://github.com/ZainRizvi due to Reverting as per offline discussion to fix internal breaks. @PaliC will reland this as a codev diff. Instructions here: https://fburl.com/fixing-ghfirst-reverts ([comment](#158288 (comment)))

@PaliC

This reverts commit ab26d4f. Reverted #158288 on behalf of https://github.com/ZainRizvi due to Reverting as per offline discussion to fix internal breaks. @PaliC will reland this as a codev diff. Instructions here: https://fburl.com/fixing-ghfirst-reverts ([comment](#158288 (comment)))

This PR is part of the work to deprecate torch::deploy in OSS. Effectively it does 3 things to get started. 1. Remove test_deploy_interaction as we no longer need to worry about this 2. Remove all torch._running_with_deploy checks and use the False path always (surfaced 1) 3. Remove `USE_DEPLOY` and switch to the default path always Note: MyPy does fail on a bunch of things here as a bunch of older files are touched. It may be better to fix these things on a separate PR Pull Request resolved: #158288 Approved by: https://github.com/albanD

ghstack-source-id: 04be446 Pull-Request: #158541

Pull Request resolved: #158541 Approved by: https://github.com/ezyang

Pull Request resolved: pytorch#158541 Approved by: https://github.com/ezyang

Update

7f7d59d

[ghstack-poisoned]

PaliC requested review from eqy and syed-ahmed as code owners July 14, 2025 22:20

pytorch-bot bot added ciflow/inductor module: dynamo module: inductor oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: distributed (fsdp) release notes category labels Jul 14, 2025

PaliC marked this pull request as draft July 14, 2025 22:21

Update

f03c02a

[ghstack-poisoned]

This was referenced Jul 14, 2025

[BE] Remove torch deploy | remove torch deploy specific files #158290

Closed

[BE] Remove __reduce_deploy__ #158291

Closed

PaliC requested a review from albanD July 15, 2025 01:53

PaliC marked this pull request as ready for review July 15, 2025 01:54

PaliC requested a review from malfet July 15, 2025 01:56

Update

f40e01b

[ghstack-poisoned]

PaliC requested a review from janeyx99 July 15, 2025 02:10

Update

e7bf204

[ghstack-poisoned]

albanD approved these changes Jul 15, 2025

View reviewed changes

Update

f078133

[ghstack-poisoned]

albanD approved these changes Jul 15, 2025

View reviewed changes

This was referenced Jul 15, 2025

[BE][EZ] Remove has_pyobj_nonhermetic from PyObjectSlot #158387

Closed

[BE] Modify PyObjectSlot the assume only a single interpreter is in use #158407

Closed

[BE] Make PyObjectSlot use a global PyInterpreter #158409

Open

pytorchmergebot reopened this Jul 25, 2025

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jul 28, 2025

pytorchmergebot added the merging label Jul 29, 2025

pytorchmergebot closed this in 6162e65 Jul 29, 2025

pytorchmergebot removed the merging label Jul 29, 2025

XuehaiPan added a commit that referenced this pull request Aug 25, 2025

[BE][Easy] restore #157584 after #158288

ad28603

ghstack-source-id: 04be446 Pull-Request: #158541

github-actions bot deleted the gh/PaliC/12/head branch August 29, 2025 02:11

pytorchmergebot pushed a commit that referenced this pull request Sep 2, 2025

[BE][Easy] restore #157584 after #158288 (#158541)

13d66e2

Pull Request resolved: #158541 Approved by: https://github.com/ezyang

markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025

[BE][Easy] restore pytorch#157584 after pytorch#158288 (pytorch#158541)

52fed77

Pull Request resolved: pytorch#158541 Approved by: https://github.com/ezyang

mansiag05 pushed a commit to mansiag05/pytorch that referenced this pull request Sep 22, 2025

[BE][Easy] restore pytorch#157584 after pytorch#158288 (pytorch#158541)

cbace90

Pull Request resolved: pytorch#158541 Approved by: https://github.com/ezyang

[BE] remove torch deploy - conditionals #158288

[BE] remove torch deploy - conditionals #158288

Uh oh!

Conversation

PaliC commented Jul 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Jul 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/158288

✅ You can merge normally! (2 Unrelated Failures)

Uh oh!

albanD left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

albanD Jul 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pytorchmergebot commented Jul 15, 2025

Uh oh!

pytorchmergebot commented Jul 15, 2025

Uh oh!

pytorchmergebot commented Jul 16, 2025

Uh oh!

PaliC commented Jul 25, 2025

Uh oh!

pytorch-bot bot commented Jul 25, 2025

Uh oh!

ZainRizvi commented Jul 25, 2025

Uh oh!

pytorchmergebot commented Jul 25, 2025

Uh oh!

pytorchmergebot commented Jul 25, 2025

Uh oh!

PaliC commented Jul 28, 2025

Uh oh!

PaliC commented Jul 29, 2025

Uh oh!

pytorchmergebot commented Jul 29, 2025

Merge started

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

PaliC commented Jul 14, 2025 •

edited

Loading

pytorch-bot bot commented Jul 14, 2025 •

edited

Loading

albanD Jul 15, 2025 •

edited

Loading