adds available_device to test_precision_recall_curve #3335 #3368
+77
−65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vfdev-5
reviewed
Mar 28, 2025
vfdev-5
reviewed
Mar 29, 2025
(otherwize type error on on MPS)
vfdev-5
reviewed
Apr 14, 2025
|
|
||
| assert pytest.approx(precision) == sk_precision | ||
| assert pytest.approx(recall) == sk_recall | ||
| assert np.allclose(precision, sk_precision, rtol=1e-6) |
There was a problem hiding this comment.
from what I understand, pytest.approx may convert float32 parameter into float64. This would break on MPS
…ision, recall and thresholds
vfdev-5
reviewed
Apr 24, 2025
vfdev-5
reviewed
Apr 28, 2025
There was a problem hiding this comment.
Thanks for working on this PR @BanzaiTokyo !
Few more comments to address
BanzaiTokyo
commented
Apr 28, 2025
vfdev-5
approved these changes
Apr 28, 2025
There was a problem hiding this comment.
Thanks @BanzaiTokyo ! Let's land it if all tests are passing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.