Skip to content

Fix codegen broadcasting for tile indexing on size-1 tensor dimensions #1300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
oulgen merged 1 commit into from
Dec 23, 2025
Merged

Fix codegen broadcasting for tile indexing on size-1 tensor dimensions #1300

oulgen merged 1 commit into from
Dec 23, 2025

Conversation

@oulgen
Copy link
Contributor

@oulgen oulgen commented Dec 22, 2025 •
edited
Loading

Stacked PRs:

Fix codegen broadcasting for tile indexing on size-1 tensor dimensions

Fixes #1287

This was referenced Dec 22, 2025
Merged
Merged
Merged
Merged
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Dec 22, 2025
@oulgen oulgen changed the base branch from oulgen/stack/189 to main December 22, 2025 22:26
@oulgen oulgen changed the base branch from main to oulgen/stack/189 December 22, 2025 22:26
@oulgen oulgen changed the base branch from oulgen/stack/189 to main December 22, 2025 22:40
@oulgen oulgen changed the base branch from main to oulgen/stack/189 December 22, 2025 22:41
@oulgen oulgen mentioned this pull request Dec 22, 2025
Merged
@oulgen oulgen changed the base branch from oulgen/stack/189 to main December 23, 2025 05:39
oulgen added a commit that referenced this pull request Dec 23, 2025
@oulgen
Fix codegen broadcasting for tile indexing on size-1 tensor dimensions
c270853 
Fixes #1287

stack-info: PR: #1300, branch: oulgen/stack/190
@oulgen oulgen changed the base branch from main to oulgen/stack/189 December 23, 2025 05:39
@oulgen oulgen changed the base branch from oulgen/stack/189 to main December 23, 2025 06:39
oulgen added a commit that referenced this pull request Dec 23, 2025
@oulgen
Fix codegen broadcasting for tile indexing on size-1 tensor dimensions
be94b85 
Fixes #1287

stack-info: PR: #1300, branch: oulgen/stack/190
@oulgen oulgen changed the base branch from main to oulgen/stack/189 December 23, 2025 06:39
@oulgen oulgen changed the base branch from oulgen/stack/189 to main December 23, 2025 17:06
oulgen added a commit that referenced this pull request Dec 23, 2025
@oulgen
Fix codegen broadcasting for tile indexing on size-1 tensor dimensions
a587791 
Fixes #1287

stack-info: PR: #1300, branch: oulgen/stack/190
@oulgen oulgen changed the base branch from main to oulgen/stack/189 December 23, 2025 17:07
@oulgen oulgen changed the base branch from oulgen/stack/189 to main December 23, 2025 17:08
oulgen added a commit that referenced this pull request Dec 23, 2025
@oulgen
Fix codegen broadcasting for tile indexing on size-1 tensor dimensions
796c507 
Fixes #1287

stack-info: PR: #1300, branch: oulgen/stack/190
@oulgen oulgen changed the base branch from main to oulgen/stack/189 December 23, 2025 17:09
@oulgen oulgen changed the base branch from oulgen/stack/189 to main December 23, 2025 17:09
oulgen added a commit that referenced this pull request Dec 23, 2025
@oulgen
Fix codegen broadcasting for tile indexing on size-1 tensor dimensions
dbddb2c 
Fixes #1287

stack-info: PR: #1300, branch: oulgen/stack/190
@oulgen oulgen changed the base branch from main to oulgen/stack/189 December 23, 2025 17:09
@oulgen oulgen marked this pull request as draft December 23, 2025 17:43
@oulgen oulgen changed the base branch from oulgen/stack/189 to main December 23, 2025 17:43
oulgen added a commit that referenced this pull request Dec 23, 2025
@oulgen
Fix codegen broadcasting for tile indexing on size-1 tensor dimensions
4357bfb 
Fixes #1287

stack-info: PR: #1300, branch: oulgen/stack/190
@oulgen oulgen changed the base branch from main to oulgen/stack/189 December 23, 2025 17:43
@oulgen oulgen marked this pull request as ready for review December 23, 2025 17:43
@oulgen oulgen marked this pull request as draft December 23, 2025 18:15
@oulgen oulgen changed the base branch from oulgen/stack/189 to main December 23, 2025 18:15
oulgen added a commit that referenced this pull request Dec 23, 2025
@oulgen
Fix codegen broadcasting for tile indexing on size-1 tensor dimensions
7c4e047 
Fixes #1287

stack-info: PR: #1300, branch: oulgen/stack/190
@oulgen oulgen marked this pull request as ready for review December 23, 2025 18:15
@oulgen oulgen marked this pull request as draft December 23, 2025 18:21
@oulgen oulgen marked this pull request as ready for review December 23, 2025 18:21
@oulgen oulgen mentioned this pull request Dec 23, 2025
Merged
@oulgen oulgen marked this pull request as draft December 23, 2025 18:35
@oulgen oulgen marked this pull request as ready for review December 23, 2025 18:36
@oulgen oulgen merged commit d33752c into main Dec 23, 2025
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jansel jansel jansel approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] Conflict between broadcasting rule and shape inference for size 1 tensor at CodeGen

3 participants

@oulgen @jansel