Skip to content

Enable Windows shared libary builds by exporting all symbols #1130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Enable Windows shared libary builds by exporting all symbols #1130

wants to merge 1 commit into from

Conversation

cyyever
Copy link
Contributor

@cyyever cyyever commented Aug 26, 2025

No description provided.

@meta-cla meta-cla bot added the cla signed label Aug 26, 2025
@cyyever cyyever changed the title Enable Windows shared libary by exporting all symbols Enable Windows shared libary builds by exporting all symbols Aug 26, 2025
@cyyever
Copy link
Contributor Author

cyyever commented Aug 26, 2025

@sraikund16 FYI

@sraikund16
Copy link
Contributor

sraikund16 commented Aug 26, 2025 •
edited
Loading

@cyyever I am not sure this will fix the issue. Have you tried testing it locally?

The problem is a linking issue, not an exporting one. It looks like when we are building torch_cpu for windows, the dependency for nvperf_host.lib does not propagate from kineto if using INTERFACE IMPORTED. We might need to use the direct path as we did in the old implementation since we don't want to add these dependencies to the parent Cmake file.

@sraikund16 sraikund16 mentioned this pull request Aug 26, 2025
Open
@sraikund16
Copy link
Contributor

I think this might be the appropriate fix: #1133

@cyyever
Copy link
Contributor Author

cyyever commented Aug 26, 2025 •
edited
Loading

@sraikund16 This PR is not for fixing the PyTorch issue, it is for the Windows shared builds in general. I have tested it locally on Windows, the tests can link to kineto dll and pass.

@facebook-github-bot
Copy link
Contributor

@sraikund16 has imported this pull request. If you are a Meta employee, you can view this in D81145587.

@facebook-github-bot
Copy link
Contributor

@sraikund16 merged this pull request in 24227d4.